Add Player[color] and Player.color typing #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! |
bavalpey
approved these changes
Aug 12, 2025
Owner
|
I'll need to update the plugin for Lua ls. I'll try to remember to do that tomorrow. |
Owner
|
Will be auto updated once LuaLS/LLS-Addons#281 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Player[color]now returnsPlayerInstanceinstead ofunknown.I have also added
Player.colorfields (Player.White,Player.Red, etc) but they might overcrowd auto-completion and direct access is rare anyways (I have ever only used it for debugging, i.e. Player.White.pingTable).