Skip to content

[WIP] Gazelle plugin #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
load("@bazel_gazelle//:def.bzl", "gazelle", "gazelle_binary")
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
load("@bazel_gazelle//:def.bzl", "DEFAULT_LANGUAGES", "gazelle", "gazelle_binary")

package(default_visibility = ["//visibility:public"])

exports_files(["AUTHORS"])

gazelle_binary(
name = "gazelle_bin",
languages = ["@bazel_skylib_gazelle_plugin//bzl"],
languages = ["@bazel_skylib_gazelle_plugin//bzl"] + DEFAULT_LANGUAGES,
)

# gazelle:exclude examples
Expand All @@ -16,6 +16,21 @@ gazelle(
gazelle = "gazelle_bin",
)

gazelle(
name = "gazelle_update_repos",
args = [
"-from_file=go.mod",
"-to_macro=go_deps.bzl%go_deps",
"-prune",
],
command = "update-repos",
)

sh_binary(
name = "tidy",
srcs = ["tidy.sh"],
)

bzl_library(
name = "internal_deps",
srcs = ["internal_deps.bzl"],
Expand All @@ -24,3 +39,8 @@ bzl_library(
"@bazel_tools//tools/build_defs/repo:utils.bzl",
],
)

bzl_library(
name = "go_deps",
srcs = ["go_deps.bzl"],
)
36 changes: 24 additions & 12 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ workspace(name = "rules_dotnet")
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
load(":internal_deps.bzl", "rules_dotnet_internal_deps")

# gazelle:repo bazel_gazelle

# Fetch deps needed only locally for development
rules_dotnet_internal_deps()

Expand All @@ -11,12 +13,34 @@ load(
"//dotnet:repositories.bzl",
"dotnet_register_toolchains",
"rules_dotnet_dependencies",
"rules_dotnet_gazelle_dependencies",
)

rules_dotnet_dependencies()

dotnet_register_toolchains("dotnet", "7.0.101")

rules_dotnet_gazelle_dependencies()

# Gazelle, for generating bzl_library targets, go targets and test the dotnet gazelle plugin
load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")
load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")
load("//:go_deps.bzl", "go_deps")

# gazelle:repository_macro go_deps.bzl%go_deps
go_deps()

go_rules_dependencies()

go_register_toolchains(version = "1.20.4")

gazelle_dependencies()

load("//dotnet:gazelle_setup.bzl", "rules_dotnet_gazelle_setup")

# gazelle:repo bazel_gazelle
rules_dotnet_gazelle_setup()

# Fetch NuGet packages needed by end-users
load("//dotnet:rules_dotnet_nuget_packages.bzl", "rules_dotnet_nuget_packages")

Expand All @@ -40,18 +64,6 @@ load("@rules_pkg//:deps.bzl", "rules_pkg_dependencies")

rules_pkg_dependencies()

load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies")

############################################
# Gazelle, for generating bzl_library targets
load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

go_rules_dependencies()

go_register_toolchains(version = "1.20.5")

gazelle_dependencies()

# Used for Bazel CI
http_archive(
name = "bazelci_rules",
Expand Down
4 changes: 4 additions & 0 deletions dotnet/gazelle_setup.bzl
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
load("@rules_dotnet//:go_deps.bzl", "go_deps")

def rules_dotnet_gazelle_setup():
go_deps()
19 changes: 19 additions & 0 deletions dotnet/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,25 @@ def rules_dotnet_dependencies():
sha256 = "3a561c99e7bdbe9173aa653fd579fe849f1d8d67395780ab4770b1f381431d51",
)

def rules_dotnet_gazelle_dependencies():
http_archive(
name = "io_bazel_rules_go",
sha256 = "6dc2da7ab4cf5d7bfc7c949776b1b7c733f05e56edc4bcd9022bb249d2e2a996",
urls = [
"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.39.1/rules_go-v0.39.1.zip",
"https://github.com/bazelbuild/rules_go/releases/download/v0.39.1/rules_go-v0.39.1.zip",
],
)

http_archive(
name = "bazel_gazelle",
sha256 = "727f3e4edd96ea20c29e8c2ca9e8d2af724d8c7778e7923a854b2c80952bc405",
urls = [
"https://mirror.bazel.build/github.com/bazelbuild/bazel-gazelle/releases/download/v0.30.0/bazel-gazelle-v0.30.0.tar.gz",
"https://github.com/bazelbuild/bazel-gazelle/releases/download/v0.30.0/bazel-gazelle-v0.30.0.tar.gz",
],
)

########
# Remaining content of the file is only used to support toolchains.
########
Expand Down
Empty file added gazelle/dotnet/BUILD.bazel
Empty file.
3 changes: 3 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module github.com/bazelbuild/rules_dotnet

go 1.20
2 changes: 2 additions & 0 deletions go_deps.bzl
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
def go_deps():
pass
17 changes: 0 additions & 17 deletions internal_deps.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -20,23 +20,6 @@ def rules_dotnet_internal_deps():
sha256 = "2401b1369ef44cc42f91dc94443ef491208dbd06da1e1e10b702d8c189f098e3",
)

http_archive(
name = "io_bazel_rules_go",
sha256 = "278b7ff5a826f3dc10f04feaf0b70d48b68748ccd512d7f98bf442077f043fe3",
urls = [
"https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.41.0/rules_go-v0.41.0.zip",
"https://github.com/bazelbuild/rules_go/releases/download/v0.41.0/rules_go-v0.41.0.zip",
],
)

http_archive(
name = "bazel_gazelle",
sha256 = "d3fa66a39028e97d76f9e2db8f1b0c11c099e8e01bf363a923074784e451f809",
urls = [
"https://github.com/bazelbuild/bazel-gazelle/releases/download/v0.33.0/bazel-gazelle-v0.33.0.tar.gz",
],
)

http_archive(
name = "bazel_skylib",
sha256 = "f24ab666394232f834f74d19e2ff142b0af17466ea0c69a3f4c276ee75f6efce",
Expand Down
12 changes: 12 additions & 0 deletions tidy.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#!/usr/bin/env bash

set -eou pipefail

# To add a new go dependency, make the required changes to the go files (import and use) and then
# run this file.

cd "${BUILD_WORKSPACE_DIRECTORY}"

bazel run @go_sdk//:bin/go -- mod tidy
bazel run //:gazelle_update_repos
bazel run //:gazelle