-
-
Notifications
You must be signed in to change notification settings - Fork 594
feat(python.toolchain): support file-based default Python version #2588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6813055
feat(python.toolchain): support file-based default Python version
vonschultz e0b7a3d
Update python/private/python.bzl
aignas f2cc08a
Update python/private/python.bzl
aignas 31cb09c
Update python/private/python.bzl
aignas 86d17aa
doc: add changelog
aignas 0228b9d
Merge branch 'main' into default_version_file
aignas 2b1286d
adjust changelog
aignas f4631dc
Merge branch 'bazel-contrib:main' into default_version_file
vonschultz 4acb4d7
feat: Implement a python.defaults tag class
vonschultz 678a608
Use Label when resolving @@//:.python-version
vonschultz b5a337b
Drop support for Bazel 7.0 in python_version_env
vonschultz 1a94ad4
Explicitly watch the python version file we read
vonschultz 5bdfbe2
Stop attempting to read @@//:.python-version
vonschultz c601c06
Merge branch 'main' into default_version_file
aignas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we deprecate this in favour of the
defaults
tag_class?cc: @rickeylev what do you think?