Skip to content

chore: Bump deps #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brandonchinn178
Copy link
Contributor

Bump deps with bazel run //tools/private/update_deps:update_pip_deps

@aignas
Copy link
Collaborator

aignas commented Apr 22, 2025

FYI, the last time I did this we got a few regressions for pip compile. I'll dig for issues later.

@rickeylev
Copy link
Collaborator

cc @vam-google -- he's also interested in having the pip deps raised; it fixes something with freethreaded builds. Though he doesn't need as many bumped as far, see https://github.com/tensorflow/tensorflow/blob/master/third_party/py/rules_python1.patch

@vam-google
Copy link

vam-google commented Apr 23, 2025

Thanks @rickeylev!

tl;dr; as long as pip is 24.0 rules_python does not fully support freethreaded python.

For the context: pip 24.0 (the one currently used in rules_python) is older than python 3.13 release. Pytnon 3.13 was the first release with free threading implemetnation, which itself gave birth of new class of python wheels with C++ extensions in it. Now there are two versions: cp313 and cp313t (for example numpy-2.2.5-cp313-cp313-manylinux_2_17_x86_64.manylinux2014_x86_64.whl and numpy-2.2.5-cp313-cp313t-manylinux_2_17_x86_64.manylinux2014_x86_64.whl).

Pip prior to 24.2 version does not see that difference and will try to install non-free threaded version of a package even if the free threaded version exists. This breaks JAX's freethreaded builds in particular (e.g. jaxlib-0.6.0-cp313-cp313t-manylinux2014_aarch64.whl).

That is why we patch rules_python. I'm currently in the process of updating our key deps, and for rules_python was hoping that 1.4.rc-1 would have pip already upgraded, but unfortunately it does not. If you can get this upgrade in it would be great for us and we would be able to stop patching rules_python. I want us to live close to rules_python head, but for that we need to get rid of patching (otherwise it is too much pain to upgrade)

@groodt
Copy link
Collaborator

groodt commented Apr 23, 2025

Might be worth waiting for pip 25.1 ETA this weekend

@aignas
Copy link
Collaborator

aignas commented Apr 24, 2025

FYI, the previous bump got reverted here: #2584

It has the links to the issues that we encountered. See the comment: #908 (comment)

@groodt
Copy link
Collaborator

groodt commented Apr 27, 2025

Pip 25.1 was released https://pip.pypa.io/en/stable/news/#v25-1

So when the time comes to bump, we should aim for 25.1+

@aignas id correct that there are often quite a lot of bumpy regressions when upgrading these deps. So we should probably do it when we have no other major changes going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants