refactor: make bzlmod pass platform mapping to host repo creation #2889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
force-pushed
the
refactor.bzlmod.pass.platforms.to.host.repo
branch
from
2d4fd4a to
ce3027c
Compare
aignas
approved these changes
May 18, 2025
| @@ -384,6 +386,16 @@ toolchain_aliases repo because referencing the `python` interpreter target from | |||
| this repo causes an eager fetch of the toolchain for the host platform. | |||
| """, | |||
| attrs = { | |||
| "archs": attr.string_dict( | |||
There was a problem hiding this comment.
nit:
Suggested change
| "archs": attr.string_dict( | |
| "arch_names": attr.string_dict( |
or cpu_names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes bzlmod pass the platform metadata to the host_toolchain rule instead of
the host toolchain rule using the fixed PLATFORMS global.
This allows the bzlmod extension to modify the platforms that are available, where the
fixed PLATFORM global can't be changed.
DO NOT MERGE: awaiting #2888
Work towards #2081