Skip to content

Pass jvm_flags through scala_benchmark_jmh#1773

Open
jeremyrsmith wants to merge 2 commits into
bazel-contrib:masterfrom
jeremyrsmith:jmh-jvm-flags
Open

Pass jvm_flags through scala_benchmark_jmh#1773
jeremyrsmith wants to merge 2 commits into
bazel-contrib:masterfrom
jeremyrsmith:jmh-jvm-flags

Conversation

@jeremyrsmith

Copy link
Copy Markdown

Description

Passes jvm_flags through scala_benchmark_jmh.

Motivation

JVM flags can sometimes be necessary to run a java program (for example, when it depends on a library that needs --add-opens). Without passing it through to scala_binary, there's no way to accomplish this for a benchmark.

This is necessary, for example, when a benchmark depends on some library that needs `--add-opens`.
@jeremyrsmith

Copy link
Copy Markdown
Author

@mbland @simuons @WojciechMazur any chance of getting this reviewed/merged? It's pretty small. Thanks!

@mbland

mbland commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

@jeremyrsmith Sorry, I was on vacation all last week and forgot to mention that beforehand. I'm also in crunch mode preparing for a quick trip/leading a training for the next two days.

Before approving/merging, please add a test:

@jeremyrsmith

Copy link
Copy Markdown
Author

Thanks, will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants