refactor: Migrate java-in-srcjar build-failure test to Bazel#1851
Merged
Conversation
PawelLipski
requested review from
WojciechMazur,
mbland and
simuons
as code owners
This was referenced Jul 7, 2026
WojciechMazur
approved these changes
Jul 8, 2026
PawelLipski
changed the base branch from
refactor/jmh-reports-failure-as-bazel-test
to
master
PawelLipski
commented
Jul 8, 2026
1 task
PawelLipski
force-pushed
the
refactor/java-in-src-jar-as-bazel-test
branch
from
e7a4036 to
444f107
Compare
Move the "java sources in a source jar while expect_java_output = False" failure fixture from test_expect_failure/java_in_src_jar_when_disabled into test/java_in_src_jar, driven by expect_build_failure_test instead of the test_scala_library_expect_failure_on_java_in_src_jar_when_disabled case in test/shell/test_scala_library.sh. The source jar is now produced by a genrule (zipping a plain-text JavaSource.java via @bazel_tools//tools/zip:zipper) rather than committing a binary .srcjar.
PawelLipski
force-pushed
the
refactor/java-in-src-jar-as-bazel-test
branch
from
444f107 to
31f70ea
Compare
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tree of downstream PRs as of 2026-07-08
PR refactor: Migrate java-in-srcjar build-failure test to Bazel #1851 (THIS ONE):
master←refactor/java-in-src-jar-as-bazel-testPR refactor: Migrate toolchain-config build-failure tests to Bazel #1852:
refactor/java-in-src-jar-as-bazel-test←refactor/toolchain-config-failures-as-bazel-testPR refactor: Use package-relative targets in expect_build_failure tests #1853:
refactor/toolchain-config-failures-as-bazel-test←refactor/expect-build-failure-relative-targetsPR refactor: Migrate transitive strict-deps build-failure tests to Bazel #1854:
refactor/expect-build-failure-relative-targets←refactor/transitive-dep-failures-as-bazel-testPR refactor: Migrate resource-strip-prefix and library-suite build failures to Bazel #1855:
refactor/transitive-dep-failures-as-bazel-test←refactor/analysis-build-failures-as-bazel-testPR refactor: Migrate scala_test jvm-flags/jacoco toolchain-failure tests to Bazel #1856:
refactor/analysis-build-failures-as-bazel-test←refactor/test-run-toolchain-failures-as-bazel-testPR refactor: Migrate scala_junit_test rule-failure tests to Bazel #1857:
refactor/test-run-toolchain-failures-as-bazel-test←refactor/junit-rule-failures-as-bazel-testPR refactor: Migrate specs2 initializer-failure message tests to Bazel #1858:
refactor/junit-rule-failures-as-bazel-test←refactor/specs2-failure-messages-as-bazel-testrefactor/specs2-failure-messages-as-bazel-test←refactor/positive-nested-test-runs-as-bazel-testSummary
Migrates the "java sources in a source jar while
expect_java_output = False" failure fixture fromtest_expect_failure/java_in_src_jar_when_disabledintotest/java_in_src_jar, driven byexpect_build_failure_testinstead of thetest_scala_library_expect_failure_on_java_in_src_jar_when_disabledcase intest/shell/test_scala_library.sh.Test plan
bazel test //test/java_in_src_jar:java_in_src_jar_when_disabled_build_test