Skip to content

feat(LanguageSupport): Allow enabling/disabling language support functionality#636

Open
cbandera wants to merge 1 commit into
bazel-contrib:masterfrom
cbandera:feature/490-language-support
Open

feat(LanguageSupport): Allow enabling/disabling language support functionality#636
cbandera wants to merge 1 commit into
bazel-contrib:masterfrom
cbandera:feature/490-language-support

Conversation

@cbandera

@cbandera cbandera commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Create single LanguageSupportFeature that handles both external LSP and built-in implementations
  • Automatically choose implementation based on bazel.lsp.command configuration (as it was)
  • Refactor LSP client management to prevent duplicate output channels (when re-enabling)
  • Ensure proper resource cleanup and disposable management
  • Rename lsp folder to language_support

Related Issue

Related to #490

Testing

  • Tests added/updated
  • Manual testing performed

Checklist

  • Code follows the project's style guidelines (prettier/eslint)
  • Commit messages follow Conventional Commit conventions
  • Tests pass locally (npm run test)

…tionality

- Create single LanguageSupportFeature that handles both external LSP and built-in implementations
- Automatically choose implementation based on bazel.lsp.command configuration (as it was)
- Refactor LSP client management to prevent duplicate output channels (when re-enabling)
- Ensure proper resource cleanup and disposable management
- Rename lsp folder to language_support
@cbandera cbandera force-pushed the feature/490-language-support branch from 607e152 to ee45f3e Compare May 11, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant