build: Activate more eslint rules#642
Open
cbandera wants to merge 11 commits into
Open
Conversation
cbandera
requested review from
cameron-martin,
coeuvre,
jfirebaugh and
vogelsgesang
as code owners
cbandera
force-pushed
the
feature/activate-more-eslint-rules
branch
from
07a1fd1 to
7519984
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In reaction to #639 and hopefully along the lines of #623, this PR activates some copilot-recommended eslint rules that could help me to better handle typescript and async code in the next PRs.
I have placed each rule activation and necessary fixes into it's own commit to ease reviewing and/or dropping individual rules based on reviews - I assume some rules could spark discussions.
Finally, I also added a block of rules that all require
strictNullCheckto be activated first - and I totally see why we should do that.Related Issue
Testing
Checklist
npm run test)