No format for tabular data#1215
Closed
systemlogic wants to merge 2 commits into
Closed
Conversation
Not in all cases formatting of build data / code is required. Code can be written in a way which looks beautiful and easy to spot problem when maintained in tabular format maintain certain spacing between columns. Current implementation of buildfier results loosing well formatted code( manually maintained) which has been supported so long before porting to bazel.
systemlogic
requested review from
larsrc-google,
pmbethe09 and
vladmos
as code owners
Collaborator
|
Closing this PR since it's been stale for a long period and still in draft state. Feel free to reopen if it's still needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not in all cases formatting of build data / code is required. Code can be written in a way which looks beautiful and easy to spot problem when maintained in tabular format maintain certain spacing between columns. Current implementation of buildfier results loosing well formatted code( manually maintained) which has been supported so long before porting to bazel.