This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
I have a couple targets at work that indirectly call py_binary and py3_binary respectively via py_image and py3_image. Without this change, these targets trigger errors on Bazel newer than when such unions were disallowed.
Issue Number: 648
What is the new behavior?
It works.
Does this PR introduce a breaking change?
Other information
Kinda funny this issue was fixed in 2019 for all the languages but Python :) I was quite confused since we're upgrading from 0.15.0 and this got merged in 0.7.0... well now I know why that was an issue. Here's a PR that should put this issue finally to rest.