-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport redirects from 7.x.x to 6.x.x #209
Open
comius
wants to merge
13
commits into
bazelbuild:release-6.x
Choose a base branch
from
comius:backport-redirects-from7.x.x-to6.x.x
base: release-6.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Backport redirects from 7.x.x to 6.x.x #209
comius
wants to merge
13
commits into
bazelbuild:release-6.x
from
comius:backport-redirects-from7.x.x-to6.x.x
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b258c07eddf8009b2fcf93ca5e943: Restructure rules_java BEGIN_PUBLIC Restructure rules_java Design doc: https://docs.google.com/document/d/1L1JFgjpZ7SrBinb24DC_5nTIELeYDacikcme-YcA7xs/edit NEW: fixed bzl_libraries END_PUBLIC Automated rollback of commit ddaf864. *** Reason for rollback *** rollforward *** Original change description *** Automated rollback of commit befbd4f. *** Reason for rollback *** postsubmit breakage: [] *** Original change description *** Restructure rules_java BEGIN_PUBLIC Restructure rules_java Design doc: https://docs.google.com/document/d/1L1JFgjpZ7SrBinb24DC_5nTIELeYDacikcme-YcA7xs/edit END_ *** PiperOrigin-RevId: 605710436 Change-Id: I4e5f2c3fe0343cf2c77dc532b97049f2686907a5
Given the alternative mechanism of inspecting the callstack for the invocation location, this is no longer needed. PiperOrigin-RevId: 610399903 Change-Id: I29a2c222c58b13e2f09b00e9a4741a32110fa9ab
Following the decision to have those in protobuf repository. PiperOrigin-RevId: 613577920 Change-Id: Iaec46ca2eee449c63a5634dec583b7791cb10d6a
Copybara Import from bazelbuild#174 BEGIN_PUBLIC Rename `java/modules` to `java/common` (bazelbuild#174) The term "modules" is easily confused with "Bazel modules" from Bzlmod. Closes bazelbuild#174 END_PUBLIC COPYBARA_INTEGRATE_REVIEW=bazelbuild#174 from fmeum:master 5a9babe PiperOrigin-RevId: 615070661 Change-Id: I0731edb4f8ce3e6a19a742fe7fd51dbde05bd53b
PiperOrigin-RevId: 622121174 Change-Id: I4a0c6129e7529714bed9800e90831b66777170d5
PiperOrigin-RevId: 666698763 Change-Id: Ied733f052b47f6e869353c4126307576e4155598
hvadehra
previously approved these changes
Sep 2, 2024
I figured out I can make the latest version backwards compatible, which is even better. #210 |
BEGIN_PUBLIC Internal change END_PUBLIC PiperOrigin-RevId: 649624213 Change-Id: If2a33be64e989df7126b9ebc80670ed74bb50591
This reverts commit 57e9801.
@comius I presume this is no longer necessary? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypicks:
03add93 Rollforward: Restructure rules_java
01c4009 Remove migration tags pollution in the java_* rules
02df693 Remove Java proto libraries from rules_java
fa37f61 Rename
java/modules
tojava/common
000ef3c Stop returning legacy struct providers from java_toolchain_alias--
e1d7466 Expose correct symbols from Blaze
ebc3531 Add redirects for proto_registry (ProguardSpecInfo really)