Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport redirects from 7.x.x to 6.x.x #209

Open
wants to merge 13 commits into
base: release-6.x
Choose a base branch
from

Conversation

comius
Copy link
Collaborator

@comius comius commented Sep 2, 2024

Cherrypicks:
03add93 Rollforward: Restructure rules_java
01c4009 Remove migration tags pollution in the java_* rules
02df693 Remove Java proto libraries from rules_java
fa37f61 Rename java/modules to java/common
000ef3c Stop returning legacy struct providers from java_toolchain_alias--
e1d7466 Expose correct symbols from Blaze
ebc3531 Add redirects for proto_registry (ProguardSpecInfo really)

comius and others added 6 commits September 2, 2024 14:25
…b258c07eddf8009b2fcf93ca5e943: Restructure rules_java

BEGIN_PUBLIC
Restructure rules_java

Design doc: https://docs.google.com/document/d/1L1JFgjpZ7SrBinb24DC_5nTIELeYDacikcme-YcA7xs/edit

NEW: fixed bzl_libraries
END_PUBLIC

Automated rollback of commit ddaf864.

*** Reason for rollback ***

rollforward

*** Original change description ***

Automated rollback of commit befbd4f.

*** Reason for rollback ***

postsubmit breakage: []

*** Original change description ***

Restructure rules_java

BEGIN_PUBLIC
Restructure rules_java

Design doc: https://docs.google.com/document/d/1L1JFgjpZ7SrBinb24DC_5nTIELeYDacikcme-YcA7xs/edit

END_

***

PiperOrigin-RevId: 605710436
Change-Id: I4e5f2c3fe0343cf2c77dc532b97049f2686907a5
Given the alternative mechanism of inspecting the callstack for the invocation location, this is no longer needed.

PiperOrigin-RevId: 610399903
Change-Id: I29a2c222c58b13e2f09b00e9a4741a32110fa9ab
Following the decision to have those in protobuf repository.

PiperOrigin-RevId: 613577920
Change-Id: Iaec46ca2eee449c63a5634dec583b7791cb10d6a
Copybara Import from bazelbuild#174

BEGIN_PUBLIC

Rename `java/modules` to `java/common` (bazelbuild#174)

The term "modules" is easily confused with "Bazel modules" from Bzlmod.

Closes bazelbuild#174

END_PUBLIC

COPYBARA_INTEGRATE_REVIEW=bazelbuild#174 from fmeum:master 5a9babe
PiperOrigin-RevId: 615070661
Change-Id: I0731edb4f8ce3e6a19a742fe7fd51dbde05bd53b
PiperOrigin-RevId: 622121174
Change-Id: I4a0c6129e7529714bed9800e90831b66777170d5
PiperOrigin-RevId: 666698763
Change-Id: Ied733f052b47f6e869353c4126307576e4155598
@comius comius requested a review from a team as a code owner September 2, 2024 13:15
@comius comius requested a review from hvadehra September 2, 2024 13:15
hvadehra
hvadehra previously approved these changes Sep 2, 2024
@comius
Copy link
Collaborator Author

comius commented Sep 2, 2024

I figured out I can make the latest version backwards compatible, which is even better. #210

@comius comius closed this Sep 2, 2024
@comius comius reopened this Sep 5, 2024
@hvadehra
Copy link
Member

@comius I presume this is no longer necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants