Fix: Handle package.workspace key in child Cargo.toml #3442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the `package.workspace` key in child workspace fails splicing with an error similar to ``` Found manifest at /home/mlaurin/src/check_mk.git/packages/site/check-http/Cargo.toml which is a member of the workspace at /home/mlaurin/src/check_mk.git/packages/site/check-http/.. which isn't included in the crates_universe ``` Now, the key is valid in Cargo.toml when the code is organized in workspaces. It is even required for out-of-tree workspaces. See https://github.com/nox/rust-rfcs/blob/master/text/1525-cargo-workspace.md Before December, the key was ignored but would not fail splicing. The regression is most likely due to changes related to bazelbuild#3090
UebelAndre
requested changes
May 15, 2025
Library to normalize path without symlink resolution.
The trivial `PathCleanUtf8` trait mimics the `Clean` trait implemented for `PathBuf` in the `clean_path` library. https://docs.rs/clean-path/latest/clean_path/trait.Clean.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
package.workspacekey in child workspace fails splicing with an error similar toNow, the key is valid in Cargo.toml when the code is organized in workspaces. It is even required for out-of-tree workspaces. See https://github.com/nox/rust-rfcs/blob/master/text/1525-cargo-workspace.md
Before December, the key was ignored but would not fail splicing. The regression is most likely due to changes related to #3090