Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scipy to numpy functions #47

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

johnlees
Copy link
Contributor

@johnlees johnlees commented Mar 9, 2020

Please consider this pull request to your repository. The fork is the version currently installable via conda-forge. I have made the following changes, mostly by running pylint and fixing errors:

  • Change scipy array functions to numpy. The scipy functions are deprecated and cause warnings, and in future will cause errors. scipy is still used for interpolation and sparse matrices.
  • Fix a variable name in cvlognet.py:l170
  • Fix taking the negative of a list rather than array in glmnetPredict.py:l184
  • Remove some errant semicolons that found their way over from the fortran (no function, but cleans code a little)

I have also changed the setup.py so that the fortran extension is built automatically (which requires gfortran to be installed). I am not sure whether you want this change, I guess updating the installation instructions here would be needed.
There are a couple of changes to the author lines in setup.py brought in through merging you may want to revert too.

Best wishes,
John Lees

@johnlees
Copy link
Contributor Author

Fix taking the negative of a list rather than array in glmnetPredict.py:l184

This was incorrect, and has now been fixed by reverting to the original code

Copy link
Owner

@bbalasub1 bbalasub1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you get this setup.py from? It does not seem to be available in the main branch.

@johnlees
Copy link
Contributor Author

This was one I modified to get it to work with conda build. If you'd prefer, I can modify so that the one from the master branch is kept instead of these changes?

@stevemandala
Copy link

This PR would likely resolve #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants