-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scipy to numpy functions #47
base: master
Are you sure you want to change the base?
Conversation
* Fix build by invoking gfortran directly Relatively ugly hack to allow downstream packages to use the library * Clean up the build process
Fix pylint errors throughout
This was incorrect, and has now been fixed by reverting to the original code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you get this setup.py from? It does not seem to be available in the main branch.
This was one I modified to get it to work with |
This PR would likely resolve #64 |
Please consider this pull request to your repository. The fork is the version currently installable via conda-forge. I have made the following changes, mostly by running
pylint
and fixing errors:scipy
array functions tonumpy
. Thescipy
functions are deprecated and cause warnings, and in future will cause errors.scipy
is still used for interpolation and sparse matrices.cvlognet.py:l170
glmnetPredict.py:l184
I have also changed the
setup.py
so that the fortran extension is built automatically (which requiresgfortran
to be installed). I am not sure whether you want this change, I guess updating the installation instructions here would be needed.There are a couple of changes to the author lines in
setup.py
brought in through merging you may want to revert too.Best wishes,
John Lees