Skip to content

refactor:migrate onDemandTVCypressTests to NextJS#13813

Merged
amoore108 merged 12 commits intolatestfrom
WS-2221--MigrateCypressOndemandTVPageToNextJs
Mar 25, 2026
Merged

refactor:migrate onDemandTVCypressTests to NextJS#13813
amoore108 merged 12 commits intolatestfrom
WS-2221--MigrateCypressOndemandTVPageToNextJs

Conversation

@MeriemMechri
Copy link
Contributor

@MeriemMechri MeriemMechri commented Mar 19, 2026

Resolves JIRA: WS-2221

Summary

Migrate onDemandTV cypress tests to NextJS.

Code changes

  • List key code changes that have been made.

Testing

  1. List the steps required to test this PR.

Useful Links

Copilot AI review requested due to automatic review settings March 19, 2026 08:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates the onDemandTV Cypress E2E coverage into the ws-nextjs-app test suite so these page checks run as part of the Next.js app’s Cypress setup.

Changes:

  • Added a new onDemandTV Cypress spec (index.cy.js) that defines canonical + lite test suites and ATI analytics suites.
  • Updated onDemandTV shared test helper imports (tests.js) to match the Next.js Cypress folder structure (currently with path issues to fix).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
ws-nextjs-app/cypress/e2e/onDemandTV/tests.js Adjusts helper imports used by the onDemandTV test definitions (currently broken paths).
ws-nextjs-app/cypress/e2e/onDemandTV/index.cy.js New Cypress spec wiring up onDemandTV canonical/lite suites plus ATI analytics suites via runTestsForPage.
Comments suppressed due to low confidence (2)

ws-nextjs-app/cypress/e2e/onDemandTV/tests.js:2

  • This relative import path resolves to ws-nextjs-app/cypress/e2e/support/helpers/chartbeatTests, but that directory doesn’t exist. It should point at the actual helper (e.g. ws-nextjs-app/cypress/support/helpers/chartbeatTests.ts) or use an established alias, otherwise this spec will fail to load.
    ws-nextjs-app/cypress/e2e/onDemandTV/tests.js:6
  • onDemandRadioTv isn’t present under ws-nextjs-app/cypress/support/helpers, so this import path won’t resolve. The existing helper lives under the repo-root cypress/support/helpers/onDemandRadioTv.js (and other specs import it via #cypress/support/helpers/onDemandRadioTv), so update this import to match that location/alias (or add a Next.js-local copy).

You can also share your feedback on Copilot code review. Take the survey.

@MeriemMechri MeriemMechri requested a review from amoore108 March 24, 2026 10:21
@MeriemMechri MeriemMechri requested a review from holchris March 25, 2026 10:26
@amoore108 amoore108 merged commit b2b36ce into latest Mar 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants