refactor:migrate onDemandTVCypressTests to NextJS#13813
Merged
Conversation
…-MigrateCypressOndemandTVPageToNextJs
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the onDemandTV Cypress E2E coverage into the ws-nextjs-app test suite so these page checks run as part of the Next.js app’s Cypress setup.
Changes:
- Added a new onDemandTV Cypress spec (
index.cy.js) that defines canonical + lite test suites and ATI analytics suites. - Updated onDemandTV shared test helper imports (
tests.js) to match the Next.js Cypress folder structure (currently with path issues to fix).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ws-nextjs-app/cypress/e2e/onDemandTV/tests.js |
Adjusts helper imports used by the onDemandTV test definitions (currently broken paths). |
ws-nextjs-app/cypress/e2e/onDemandTV/index.cy.js |
New Cypress spec wiring up onDemandTV canonical/lite suites plus ATI analytics suites via runTestsForPage. |
Comments suppressed due to low confidence (2)
ws-nextjs-app/cypress/e2e/onDemandTV/tests.js:2
- This relative import path resolves to
ws-nextjs-app/cypress/e2e/support/helpers/chartbeatTests, but that directory doesn’t exist. It should point at the actual helper (e.g.ws-nextjs-app/cypress/support/helpers/chartbeatTests.ts) or use an established alias, otherwise this spec will fail to load.
ws-nextjs-app/cypress/e2e/onDemandTV/tests.js:6 onDemandRadioTvisn’t present underws-nextjs-app/cypress/support/helpers, so this import path won’t resolve. The existing helper lives under the repo-rootcypress/support/helpers/onDemandRadioTv.js(and other specs import it via#cypress/support/helpers/onDemandRadioTv), so update this import to match that location/alias (or add a Next.js-local copy).
You can also share your feedback on Copilot code review. Take the survey.
…-MigrateCypressOndemandTVPageToNextJs
…://github.com/bbc/simorgh into WS-2221--MigrateCypressOndemandTVPageToNextJs
…-MigrateCypressOndemandTVPageToNextJs
…-MigrateCypressOndemandTVPageToNextJs
amoore108
approved these changes
Mar 24, 2026
Louis-Matsika
approved these changes
Mar 25, 2026
…-MigrateCypressOndemandTVPageToNextJs
…://github.com/bbc/simorgh into WS-2221--MigrateCypressOndemandTVPageToNextJs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: WS-2221
Summary
Migrate onDemandTV cypress tests to NextJS.
Code changes
Testing
Useful Links