Skip to content

WS-2224 - Next batch of services with new nav#13815

Merged
amoore108 merged 13 commits intolatestfrom
WS-2224-new-nav-batch-services
Mar 25, 2026
Merged

WS-2224 - Next batch of services with new nav#13815
amoore108 merged 13 commits intolatestfrom
WS-2224-new-nav-batch-services

Conversation

@amoore108
Copy link
Contributor

@amoore108 amoore108 commented Mar 19, 2026

Resolves JIRA: https://bbc.atlassian.net/browse/WS-2224

Summary

Releases new nav to Bengali, Marathi, Telugu, Punjabi and Urdu services

Code changes

  • Adds services to SERVICES_WITH_NEW_NAV array
  • Updates the brand SVGs for each of the new nav services

Testing

  1. Visit http://localhost:7081/bengali?renderer_env=live
  2. Confirm new nav and brand renders
  3. Visit http://localhost:7081/marathi?renderer_env=live
  4. Confirm new nav and brand renders
  5. Visit http://localhost:7081/telugu?renderer_env=live
  6. Confirm new nav and brand renders
  7. Visit http://localhost:7081/punjabi?renderer_env=live
  8. Confirm new nav and brand renders
  9. Visit http://localhost:7081/urdu?renderer_env=live
  10. Confirm new nav and brand renders

Useful Links

@amoore108 amoore108 self-assigned this Mar 19, 2026
@amoore108 amoore108 marked this pull request as ready for review March 19, 2026 12:11
Copilot AI review requested due to automatic review settings March 19, 2026 12:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Rolls out the “new nav” feature flag and associated branding updates to the next batch of World Service language services in Simorgh.

Changes:

  • Expands SERVICES_WITH_NEW_NAV to include Bengali, Marathi, Punjabi, Telugu, and Urdu.
  • Updates the affected chameleon brand SVGs to use cropped viewbox settings (and removes older SVG paths/dimensions).
  • Cleans up outdated inline comments referencing Arabic/Tamil-only behavior in config fetching and Cypress nav tests.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
ws-nextjs-app/cypress/e2e/testsForAllCanonicalPages.ts Removes outdated comment about two-tier nav service limitation.
ws-nextjs-app/cypress/e2e/testsForAllAMPPages.ts Removes outdated comment about two-tier nav service limitation.
src/app/lib/utilities/fetchConfig/index.ts Removes outdated comment about Arabic/Tamil-only new-nav fetching.
src/app/components/ThemeProvider/chameleonLogos/bengali.tsx Crops/changing logo rendering via viewbox and updated paths.
src/app/components/ThemeProvider/chameleonLogos/marathi.tsx Crops/changing logo rendering via viewbox and updated paths.
src/app/components/ThemeProvider/chameleonLogos/punjabi.tsx Crops/changing logo rendering via viewbox and updated paths.
src/app/components/ThemeProvider/chameleonLogos/telugu.tsx Crops/changing logo rendering via viewbox and updated paths.
src/app/components/ThemeProvider/chameleonLogos/urdu.tsx Crops/changing logo rendering via viewbox and updated paths.
src/app/components/Navigation/config.ts Adds the new services to the “new nav” allowlist.

Copilot AI review requested due to automatic review settings March 19, 2026 14:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Rolls out the “new nav” experience to the next batch of World Service (Next.js) services by enabling the new-nav toggle for additional services and updating their brand SVGs to match the new navigation/header treatment.

Changes:

  • Expanded SERVICES_WITH_NEW_NAV to include Bengali, Marathi, Telugu, Punjabi, and Urdu (in addition to Arabic and Tamil).
  • Updated the chameleon brand SVGs for the newly enabled services (cropping/adjusting via explicit viewbox values and path updates).
  • Removed now-outdated inline comments that referenced the old “Arabic and Tamil only” limitation.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/app/components/Navigation/config.ts Adds the newly enabled services to the new-nav allowlist.
src/app/lib/utilities/fetchConfig/index.ts Keeps behavior but removes outdated comment; useNewNav=true still keyed off the allowlist.
ws-nextjs-app/cypress/e2e/testsForAllCanonicalPages.ts Removes outdated comment about two-tier nav being limited to Arabic/Tamil.
ws-nextjs-app/cypress/e2e/testsForAllAMPPages.ts Removes outdated comment about two-tier nav being limited to Arabic/Tamil.
src/app/components/ThemeProvider/chameleonLogos/bengali.tsx Updates brand SVG crop/rendering for new nav.
src/app/components/ThemeProvider/chameleonLogos/marathi.tsx Updates brand SVG crop/rendering for new nav.
src/app/components/ThemeProvider/chameleonLogos/punjabi.tsx Updates brand SVG crop/rendering for new nav.
src/app/components/ThemeProvider/chameleonLogos/telugu.tsx Updates brand SVG crop/rendering for new nav.
src/app/components/ThemeProvider/chameleonLogos/urdu.tsx Updates brand SVG crop/rendering for new nav.

@amoore108 amoore108 changed the title WS-2224 - Next batch of services with new nav [DNM] WS-2224 - Next batch of services with new nav Mar 20, 2026
@amoore108 amoore108 changed the title [DNM] WS-2224 - Next batch of services with new nav WS-2224 - Next batch of services with new nav Mar 23, 2026
@amoore108 amoore108 merged commit ded0dc4 into latest Mar 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants