WS-2224 - Next batch of services with new nav#13815
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Rolls out the “new nav” feature flag and associated branding updates to the next batch of World Service language services in Simorgh.
Changes:
- Expands
SERVICES_WITH_NEW_NAVto include Bengali, Marathi, Punjabi, Telugu, and Urdu. - Updates the affected chameleon brand SVGs to use cropped
viewboxsettings (and removes older SVG paths/dimensions). - Cleans up outdated inline comments referencing Arabic/Tamil-only behavior in config fetching and Cypress nav tests.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| ws-nextjs-app/cypress/e2e/testsForAllCanonicalPages.ts | Removes outdated comment about two-tier nav service limitation. |
| ws-nextjs-app/cypress/e2e/testsForAllAMPPages.ts | Removes outdated comment about two-tier nav service limitation. |
| src/app/lib/utilities/fetchConfig/index.ts | Removes outdated comment about Arabic/Tamil-only new-nav fetching. |
| src/app/components/ThemeProvider/chameleonLogos/bengali.tsx | Crops/changing logo rendering via viewbox and updated paths. |
| src/app/components/ThemeProvider/chameleonLogos/marathi.tsx | Crops/changing logo rendering via viewbox and updated paths. |
| src/app/components/ThemeProvider/chameleonLogos/punjabi.tsx | Crops/changing logo rendering via viewbox and updated paths. |
| src/app/components/ThemeProvider/chameleonLogos/telugu.tsx | Crops/changing logo rendering via viewbox and updated paths. |
| src/app/components/ThemeProvider/chameleonLogos/urdu.tsx | Crops/changing logo rendering via viewbox and updated paths. |
| src/app/components/Navigation/config.ts | Adds the new services to the “new nav” allowlist. |
louisearchibald
approved these changes
Mar 19, 2026
Louis-Matsika
approved these changes
Mar 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Rolls out the “new nav” experience to the next batch of World Service (Next.js) services by enabling the new-nav toggle for additional services and updating their brand SVGs to match the new navigation/header treatment.
Changes:
- Expanded
SERVICES_WITH_NEW_NAVto include Bengali, Marathi, Telugu, Punjabi, and Urdu (in addition to Arabic and Tamil). - Updated the chameleon brand SVGs for the newly enabled services (cropping/adjusting via explicit
viewboxvalues and path updates). - Removed now-outdated inline comments that referenced the old “Arabic and Tamil only” limitation.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/app/components/Navigation/config.ts |
Adds the newly enabled services to the new-nav allowlist. |
src/app/lib/utilities/fetchConfig/index.ts |
Keeps behavior but removes outdated comment; useNewNav=true still keyed off the allowlist. |
ws-nextjs-app/cypress/e2e/testsForAllCanonicalPages.ts |
Removes outdated comment about two-tier nav being limited to Arabic/Tamil. |
ws-nextjs-app/cypress/e2e/testsForAllAMPPages.ts |
Removes outdated comment about two-tier nav being limited to Arabic/Tamil. |
src/app/components/ThemeProvider/chameleonLogos/bengali.tsx |
Updates brand SVG crop/rendering for new nav. |
src/app/components/ThemeProvider/chameleonLogos/marathi.tsx |
Updates brand SVG crop/rendering for new nav. |
src/app/components/ThemeProvider/chameleonLogos/punjabi.tsx |
Updates brand SVG crop/rendering for new nav. |
src/app/components/ThemeProvider/chameleonLogos/telugu.tsx |
Updates brand SVG crop/rendering for new nav. |
src/app/components/ThemeProvider/chameleonLogos/urdu.tsx |
Updates brand SVG crop/rendering for new nav. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2224
Summary
Releases new nav to Bengali, Marathi, Telugu, Punjabi and Urdu services
Code changes
SERVICES_WITH_NEW_NAVarrayTesting
Useful Links