Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the High Impact Promo curation component to display a relatedTopic link (when provided) in place of the usual attribution, aligning promo rendering with updated backend payload expectations.
Changes:
- Add optional
relatedTopicprop toHighImpactPromoand prefer it overattributionswhen rendering the subject link. - Refactor subject-link selection logic to fall back to first attribution or brand link/text when
relatedTopicis absent. - Extend unit tests to cover rendering and prioritisation of
relatedTopic.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/app/components/Curation/HighImpactPromo/index.tsx | Adds relatedTopic support and prioritised rendering logic over attributions. |
| src/app/components/Curation/HighImpactPromo/index.test.tsx | Adds test coverage for relatedTopic rendering and precedence over attributions. |
…elatedtopic-instead-of-attribution
…nstead-of-attribution' of https://github.com/bbc/simorgh into WS-2315-simorgh-high-impact-promo-to-use-relatedtopic-instead-of-attribution
jinidev
reviewed
Mar 24, 2026
…elatedtopic-instead-of-attribution
emilysaffron
approved these changes
Mar 24, 2026
jinidev
approved these changes
Mar 24, 2026
…nstead-of-attribution' of https://github.com/bbc/simorgh into WS-2315-simorgh-high-impact-promo-to-use-relatedtopic-instead-of-attribution
elvinasv
reviewed
Mar 25, 2026
Member
elvinasv
left a comment
There was a problem hiding this comment.
Ask talked offline, given that we're introduced relatedTopic which contains the primary topic of the article, should we remove the attributions for HighImpactPromo?
There may be unintended consequences if topics are missing but attributions are still returned, especially since Editorial might not have an easy way to control this.
elvinasv
reviewed
Mar 25, 2026
elvinasv
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2315
Summary
A follow up to #13570 after discussing its caveats with the article team (change affect PS pages).
This change fixes how related topic data is passed down from BFF. When received, this new
relatedTopicproperty is then conditionally rendered in MAXIMUM visual prominence HIP components in Simorgh instead of a regular article attribution.Code changes
Testing
Useful Links