WS-2627: My News page front end improvements#14080
Open
elvinasv wants to merge 10 commits into
Open
Conversation
elvinasv
commented
Jun 1, 2026
Member
Author
There was a problem hiding this comment.
Note: Extracted for reusability from AccountPromotionalBanner - no new changes
elvinasv
commented
Jun 2, 2026
| removing: 'Removing', | ||
| }, | ||
| myNews: { | ||
| title: 'My News', |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the WS Next.js “My News” page UI to better match design, adds translated copy for Hindi, introduces a reusable spinner component, and extracts reusable account sign-in/register action buttons from the account promotional banner for reuse on the My News guest state.
Changes:
- Refactors My News page layout/styling (new styles location, updated headings/spacing, increased items-per-page to 24).
- Reworks My News loading + guest states (spinner-based loading UI, guest CTA buttons) and updates tests accordingly.
- Extracts
AccountActionButtonsfor reuse, and introduces a sharedSpinnercomponent (also adopted bySaveButton).
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ws-nextjs-app/pages/[service]/my-news/styles.ts | Removes old shared My News styles file (styles moved into MyNewsPage subfolder). |
| ws-nextjs-app/pages/[service]/my-news/MyNewsPage/styles.ts | Adds updated My News page styles (heading/subheading spacing + spinner sizing/wrapping). |
| ws-nextjs-app/pages/[service]/my-news/MyNewsPage/MyNewsPageLoading.tsx | Updates loading state to use a spinner and translated page title. |
| ws-nextjs-app/pages/[service]/my-news/MyNewsPage/MyNewsPageGuest/styles.ts | Adds guest-state layout styles (heading + CTA button container). |
| ws-nextjs-app/pages/[service]/my-news/MyNewsPage/MyNewsPageGuest/index.tsx | Introduces guest-state component using translations + AccountActionButtons. |
| ws-nextjs-app/pages/[service]/my-news/MyNewsPage/MyNewsPageGuest.tsx | Removes legacy placeholder guest component. |
| ws-nextjs-app/pages/[service]/my-news/MyNewsPage/MyNewsPageContent.tsx | Uses translations for metadata/title/error/empty states; increases items-per-page; adds a subheading before saved-articles grid. |
| ws-nextjs-app/pages/[service]/my-news/MyNewsPage/index.tsx | Uses translations for metadata title and guards rendering; updates styles import path. |
| ws-nextjs-app/pages/[service]/my-news/MyNewsPage/index.test.tsx | Updates tests for spinner loading UI, items-per-page change, and guest CTA rendering. |
| src/app/models/types/translations.ts | Adds myNews translations shape to the Translations type. |
| src/app/lib/config/services/hindi.ts | Adds Hindi service config myNews translation strings. |
| src/app/components/Spinner/index.tsx | Adds new reusable Spinner component. |
| src/app/components/Spinner/index.styles.ts | Adds spinner keyframes + animation styling. |
| src/app/components/SaveButton/index.tsx | Switches SaveButton to use the new shared Spinner component. |
| src/app/components/SaveButton/index.styles.ts | Removes SaveButton-specific spinner animation styles now covered by shared spinner. |
| src/app/components/PromotionalBanner/index.styles.ts | Removes redundant justifyContent: 'flex-start' in banner actions container. |
| src/app/components/Account/AccountPromotionalBanner/index.tsx | Replaces inline CTA link markup with extracted AccountActionButtons. |
| src/app/components/Account/AccountPromotionalBanner/index.styles.tsx | Removes CTA/button styling now owned by AccountActionButtons. |
| src/app/components/Account/AccountActionButtons/index.tsx | Adds reusable sign-in/register CTA component (used by promo banner + My News guest state). |
| src/app/components/Account/AccountActionButtons/index.styles.tsx | Adds styling for the extracted account CTA buttons, including light-background variants. |
jinidev
approved these changes
Jun 3, 2026
LukasFrm
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://bbc.atlassian.net/browse/WS-2627
Summary
Code changes
AccountActionButtonsfrom Account Promotional banner for reusabilityTesting
x-id-oidc-signedin: 1 | 0(sign-in/sign-out states) as a Request HeaderUseful Links