WS-2638 - MAP Promo Playback on Homepage and Topics [SPIKE]#14087
Draft
pvaliani wants to merge 4 commits into
Draft
WS-2638 - MAP Promo Playback on Homepage and Topics [SPIKE]#14087pvaliani wants to merge 4 commits into
pvaliani wants to merge 4 commits into
Conversation
andrewscfc
reviewed
Jun 4, 2026
| promo, | ||
| promoIndex, | ||
| mediaBlocks, | ||
| }: Props): InSituPlaybackEligibility => { |
Contributor
There was a problem hiding this comment.
So is this a blanket rule for every hieirachicalGrid view the first promo will show as in-situ playback.
It's not just if its the first curation on the page?
(would be uncomfortable with the latter as it starts to make the rendering very unpredictable)
andrewscfc
reviewed
Jun 4, 2026
Comment on lines
+98
to
+107
| const inSituPlaybackEligibility = getInSituPlaybackEligibility({ | ||
| promo, | ||
| promoIndex: i, | ||
| mediaBlocks: promo.inSituMedia, | ||
| }); | ||
| const eligibleInSituMediaBlocks = | ||
| !isAmp && inSituPlaybackEligibility.isEligible | ||
| ? inSituPlaybackEligibility.mediaBlocks | ||
| : null; | ||
| const inSituMediaBlocks = eligibleInSituMediaBlocks; |
Contributor
There was a problem hiding this comment.
From a maintainability standpoint this logic definitely belongs in the BFF as it is pure business logic
andrewscfc
reviewed
Jun 4, 2026
| VISUAL_PROMINENCE, | ||
| VISUAL_STYLE, | ||
| } from '#app/models/types/curationData'; | ||
| import getPageData from '../pageRequests/getPageData'; |
Contributor
There was a problem hiding this comment.
I think there is a lot of logic that belongs in the BFF in this file, I'd try and only send to the frontend what is need to render nothing more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA:
https://bbc.atlassian.net/browse/WS-2638
Summary
Screen.Recording.2026-06-03.at.15.40.05.mov
Code changes
Testing
Test link: http://localhost.bbc.com:7081/arabic/topics/cz9mm6r1q5et?renderer_env=live
Useful Links