Fix for sanitizer's initialization-order-fiasco - #891
Closed
heshpdx wants to merge 1 commit into
Closed
Conversation
Another fix related to bbuchfink#877. This one is in the construction of the matrices for blosum and pam. We fix the undefined behavior by creating static methods to construct on first use. AddressSanitizer: initialization-order-fiasco src/basic/basic.cpp:281:16 in Reduction::Reduction(char const*) located 3912 bytes inside of global variable 'Stats::blosum62' defined in 'src/stats/matrices/blosum62.cpp:25' of size 10344
Owner
|
Sorry for the delay, important deadline. |
Contributor
Author
|
Ok no problem. I'm going to keep this code for SPEC CPU since I know it already works, and we have passed Step 4. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another fix related to #877. This one is in the construction of the matrices for blosum and pam. We fix the undefined behavior by creating static methods to construct on first use.