reduce number of Error Prone warnings and some other IDE warnings

core/src/main/java/org/bouncycastle/asn1/BERBitStringParser.java

@@ -10,6 +10,7 @@
  * 
  * @deprecated Check for 'ASN1BitStringParser' instead 
  */
+@Deprecated
 public class BERBitStringParser
     implements ASN1BitStringParser
 {

core/src/main/java/org/bouncycastle/asn1/BEROctetStringParser.java

@@ -10,6 +10,7 @@
  * 
  * @deprecated Check for 'ASN1OctetStringParser' instead 
  */
+@Deprecated
 public class BEROctetStringParser
     implements ASN1OctetStringParser
 {

core/src/main/java/org/bouncycastle/asn1/BERSequenceParser.java

@@ -7,6 +7,7 @@
  * 
  * @deprecated Check for 'ASN1SequenceParser' instead 
  */
+@Deprecated
 public class BERSequenceParser
     implements ASN1SequenceParser
 {

core/src/main/java/org/bouncycastle/asn1/BERSetParser.java

@@ -7,6 +7,7 @@
  * 
  * @deprecated Check for 'ASN1SetParser' instead 
  */
+@Deprecated
 public class BERSetParser
     implements ASN1SetParser
 {

core/src/main/java/org/bouncycastle/asn1/DERExternal.java

@@ -20,6 +20,7 @@ public class DERExternal
      * 
      * @deprecated Use {@link DERExternal#DERExternal(DERSequence)} instead.
      */
+    @Deprecated
     public DERExternal(ASN1EncodableVector vector)
     {
         this(DERFactory.createSequence(vector));

core/src/main/java/org/bouncycastle/asn1/DEROctetStringParser.java

@@ -8,6 +8,7 @@
  * 
  * @deprecated Check for 'ASN1OctetStringParser' instead 
  */
+@Deprecated
 public class DEROctetStringParser
     implements ASN1OctetStringParser
 {

core/src/main/java/org/bouncycastle/asn1/DLBitStringParser.java

@@ -8,6 +8,7 @@
  * 
  * @deprecated Check for 'ASN1BitStringParser' instead 
  */
+@Deprecated
 public class DLBitStringParser
     implements ASN1BitStringParser
 {

core/src/main/java/org/bouncycastle/asn1/DLExternal.java

@@ -20,6 +20,7 @@ public class DLExternal
      * 
      * @deprecated Use {@link DLExternal#DLExternal(DLSequence)} instead.
      */
+    @Deprecated
     public DLExternal(ASN1EncodableVector vector)
     {
         this(DLFactory.createSequence(vector));

core/src/main/java/org/bouncycastle/asn1/DLSequenceParser.java

@@ -7,6 +7,7 @@
  * 
  * @deprecated Check for 'ASN1SequenceParser' instead 
  */
+@Deprecated
 public class DLSequenceParser
     implements ASN1SequenceParser
 {

core/src/main/java/org/bouncycastle/asn1/DLSetParser.java

@@ -7,6 +7,7 @@
  * 
  * @deprecated Check for 'ASN1SetParser' instead 
  */
+@Deprecated
 public class DLSetParser
     implements ASN1SetParser
 {

core/src/main/java/org/bouncycastle/asn1/pkcs/PKCSObjectIdentifiers.java

@@ -195,6 +195,7 @@ public interface PKCSObjectIdentifiers
 
     /** PKCS#9: 1.2.840.113549.1.9.22.1
      * @deprecated use x509Certificate instead */
+    @Deprecated
     ASN1ObjectIdentifier    x509certType            = pkcs_9.branch("22.1");
 
     /** PKCS#9: 1.2.840.113549.1.9.22 */
@@ -246,6 +247,7 @@ public interface PKCSObjectIdentifiers
     /** S/MIME: Algorithm Identifiers ; 1.2.840.113549.1.9.16.3 */
     ASN1ObjectIdentifier smime_alg = id_smime.branch("3");
     /** @deprecated use smime_alg instead */
+    @Deprecated
     ASN1ObjectIdentifier id_alg = id_smime.branch("3");
 
     /** PKCS#9: 1.2.840.113549.1.9.16.3.5 */
@@ -417,12 +419,16 @@ public interface PKCSObjectIdentifiers
     ASN1ObjectIdentifier id_aa_communityIdentifiers = id_aa.branch("40");
 
     /** @deprecated use id_aa_ets_sigPolicyId instead */
+    @Deprecated
     ASN1ObjectIdentifier id_aa_sigPolicyId    = id_aa_ets_sigPolicyId;
     /** @deprecated use id_aa_ets_commitmentType instead */
+    @Deprecated
     ASN1ObjectIdentifier id_aa_commitmentType = id_aa_ets_commitmentType;
     /** @deprecated use id_aa_ets_signerLocation instead */
+    @Deprecated
     ASN1ObjectIdentifier id_aa_signerLocation = id_aa_ets_signerLocation;
     /** @deprecated use id_aa_ets_otherSigCert instead */
+    @Deprecated
     ASN1ObjectIdentifier id_aa_otherSigCert   = id_aa_ets_otherSigCert;
 
     /**
@@ -431,6 +437,7 @@ public interface PKCSObjectIdentifiers
      * 1.2.840.113549.1.9.16.5
      * @deprecated use id_spq_oid instead
      */
+    @Deprecated
     final String id_spq = "1.2.840.113549.1.9.16.5";
     ASN1ObjectIdentifier id_spq_oid = id_smime.branch("5");
 
@@ -481,6 +488,7 @@ public interface PKCSObjectIdentifiers
      * PKCS#12: 1.2.840.113549.1.12.1.6
      * @deprecated use pbeWithSHAAnd40BitRC2_CBC
      */
+    @Deprecated
     ASN1ObjectIdentifier    pbewithSHAAnd40BitRC2_CBC = pkcs_12PbeIds.branch("6");
 }
 

core/src/main/java/org/bouncycastle/asn1/x509/SubjectPublicKeyInfo.java

@@ -74,6 +74,7 @@ public SubjectPublicKeyInfo(
     /**
      @deprecated use SubjectPublicKeyInfo.getInstance()
      */
+    @Deprecated
     public SubjectPublicKeyInfo(
         ASN1Sequence  seq)
     {
@@ -98,6 +99,7 @@ public AlgorithmIdentifier getAlgorithm()
      * @deprecated use getAlgorithm()
      * @return    alg ID.
      */
+    @Deprecated
     public AlgorithmIdentifier getAlgorithmId()
     {
         return algId;
@@ -126,6 +128,7 @@ public ASN1Primitive parsePublicKey()
      * @deprecated use parsePublicKey
      * @return the public key as an ASN.1 primitive.
      */
+    @Deprecated
     public ASN1Primitive getPublicKey()
         throws IOException
     {

core/src/main/java/org/bouncycastle/crypto/AsymmetricCipherKeyPair.java

@@ -31,6 +31,7 @@ public AsymmetricCipherKeyPair(
      * @param privateParam the corresponding private key parameters.
      * @deprecated use AsymmetricKeyParameter
      */
+    @Deprecated
     public AsymmetricCipherKeyPair(
         CipherParameters    publicParam,
         CipherParameters    privateParam)

core/src/main/java/org/bouncycastle/crypto/engines/AESEngine.java

@@ -435,6 +435,7 @@ public static MultiBlockCipher newInstance()
      * default constructor - 128 bit block size.
      * @deprecated use AESEngine.newInstance()
      */
+    @Deprecated
     public AESEngine()
     {
         CryptoServicesRegistrar.checkConstraints(new DefaultServiceProperties(getAlgorithmName(), 256));

core/src/main/java/org/bouncycastle/crypto/engines/RSABlindedEngine.java

@@ -28,7 +28,7 @@ public class RSABlindedEngine
      * initialise the RSA engine.
      *
      * @param forEncryption true if we are encrypting, false otherwise.
-     * @param param the necessary RSA key parameters.
+     * @param parameters the necessary RSA key parameters.
      */
     public void init(boolean forEncryption, CipherParameters parameters)
     {

core/src/main/java/org/bouncycastle/crypto/modes/SICBlockCipher.java

@@ -41,6 +41,7 @@ public static CTRModeCipher newInstance(BlockCipher cipher)
      * @param c the block cipher to be used.
      * @deprecated use newInstance() method.
      */
+    @Deprecated
     public SICBlockCipher(BlockCipher c)
     {
         super(c);

core/src/main/java/org/bouncycastle/crypto/params/SAKKEPublicKeyParameters.java

@@ -191,7 +191,7 @@ public Digest getDigest()
     }
 
     /**
-     * @return The pairing result g = <P,P> (RFC 6508, Section 3.2)
+     * @return The pairing result {@code g = <P,P>} (RFC 6508, Section 3.2)
      */
     public BigInteger getG()
     {

core/src/main/java/org/bouncycastle/math/ec/ECCurve.java

@@ -691,6 +691,7 @@ public static class Fp extends AbstractFp
         /**
          * @deprecated use constructor taking order/cofactor
          */
+        @Deprecated
         public Fp(BigInteger q, BigInteger a, BigInteger b)
         {
             this(q, a, b, null, null);
@@ -1153,6 +1154,7 @@ public static class F2m extends AbstractF2m
          * <code>F<sub>2<sup>m</sup></sub></code>.
          * @deprecated use constructor taking order/cofactor
          */
+        @Deprecated
         public F2m(
             int m,
             int k,
@@ -1211,6 +1213,7 @@ public F2m(
          * <code>F<sub>2<sup>m</sup></sub></code>.
          * @deprecated use constructor taking order/cofactor
          */
+        @Deprecated
         public F2m(
             int m,
             int k1,

core/src/main/java/org/bouncycastle/pqc/asn1/CMCEPublicKey.java

@@ -34,6 +34,7 @@ public CMCEPublicKey(byte[] t)
     /**
      * @deprecated use getInstance()
      */
+    @Deprecated
     public CMCEPublicKey(ASN1Sequence seq)
     {
         T = Arrays.clone(ASN1OctetString.getInstance(seq.getObjectAt(0)).getOctets());

core/src/main/java/org/bouncycastle/pqc/asn1/FalconPublicKey.java

@@ -32,6 +32,7 @@ public byte[] getH()
     /**
      * @deprecated use getInstance()
      */
+    @Deprecated
     public FalconPublicKey(ASN1Sequence seq)
     {
         h = Arrays.clone(ASN1OctetString.getInstance(seq.getObjectAt(0)).getOctets());

core/src/main/java/org/bouncycastle/pqc/asn1/KyberPublicKey.java

@@ -36,6 +36,7 @@ public KyberPublicKey(byte[] t, byte[] rho)
     /**
      * @deprecated use getInstance()
      */
+    @Deprecated
     public KyberPublicKey(ASN1Sequence seq)
     {
         t = Arrays.clone(ASN1OctetString.getInstance(seq.getObjectAt(0)).getOctets());

core/src/main/java/org/bouncycastle/pqc/asn1/PQCObjectIdentifiers.java

@@ -86,35 +86,43 @@ public interface PQCObjectIdentifiers
     /**
      * @deprecated use xmss_SHA256ph
      */
+    @Deprecated
     final ASN1ObjectIdentifier xmss_with_SHA256          = xmss_SHA256ph;
     /**
      * @deprecated use xmss_SHA512ph
      */
+    @Deprecated
     final ASN1ObjectIdentifier xmss_with_SHA512 = xmss_SHA512ph;
     /**
      * @deprecated use xmss_SHAKE128ph
      */
+    @Deprecated
     final ASN1ObjectIdentifier xmss_with_SHAKE128 = xmss_SHAKE128ph;
     /**
      * @deprecated use xmss_SHAKE256ph
      */
+    @Deprecated
     final ASN1ObjectIdentifier xmss_with_SHAKE256        = xmss_SHAKE256ph;
 
     /**
      * @deprecated use xmss_mt_SHA256ph
      */
+    @Deprecated
     final ASN1ObjectIdentifier xmss_mt_with_SHA256          = xmss_mt_SHA256ph;
     /**
      * @deprecated use xmss_mt_SHA512ph
      */
+    @Deprecated
     final ASN1ObjectIdentifier xmss_mt_with_SHA512          = xmss_mt_SHA512ph;
     /**
      * @deprecated use xmss_mt_SHAKE128ph
      */
+    @Deprecated
     final ASN1ObjectIdentifier xmss_mt_with_SHAKE128        = xmss_mt_SHAKE128ph;
     /**
      * @deprecated use xmss_mt_SHAKE256ph
      */
+    @Deprecated
     final ASN1ObjectIdentifier xmss_mt_with_SHAKE256        = xmss_mt_SHAKE256ph;
 
     /**

core/src/main/java/org/bouncycastle/pqc/asn1/SPHINCSPLUSPrivateKey.java

@@ -68,6 +68,7 @@ public SPHINCSPLUSPrivateKey(int version, byte[] skseed, byte[] skprf, SPHINCSPL
     /**
      * @deprecated use getInstance()
      */
+    @Deprecated
     public SPHINCSPLUSPrivateKey(ASN1Sequence seq)
     {
         version = ASN1Integer.getInstance(seq.getObjectAt(0)).intValueExact();

core/src/main/java/org/bouncycastle/pqc/asn1/SPHINCSPLUSPublicKey.java

@@ -29,6 +29,7 @@ public SPHINCSPLUSPublicKey(byte[] pkseed, byte[] pkroot)
     /**
      * @deprecated use getInstance()
      */
+    @Deprecated
     public SPHINCSPLUSPublicKey(ASN1Sequence seq)
     {
         pkseed = Arrays.clone(ASN1OctetString.getInstance(seq.getObjectAt(0)).getOctets());

core/src/main/java/org/bouncycastle/pqc/crypto/crystals/dilithium/DilithiumParameters.java

@@ -15,6 +15,7 @@ public class DilithiumParameters
      * @deprecated
      * obsolete to be removed
      */
+    @Deprecated
     private final boolean usingAES;// or shake
 
     private DilithiumParameters(String name, int k, boolean usingAES)

core/src/main/java/org/bouncycastle/pqc/crypto/crystals/dilithium/DilithiumPrivateKeyParameters.java

@@ -63,6 +63,7 @@ public byte[] getK()
     }
 
     /** @deprecated Use {@link #getEncoded()} instead. */
+    @Deprecated
     public byte[] getPrivateKey()
     {
         return getEncoded();

core/src/main/java/org/bouncycastle/pqc/crypto/mldsa/MLDSAPrivateKeyParameters.java

@@ -138,6 +138,7 @@ public byte[] getK()
     /**
      * @deprecated Use {@link #getEncoded()} instead.
      */
+    @Deprecated
     public byte[] getPrivateKey()
     {
         return getEncoded();

core/src/main/java/org/bouncycastle/pqc/crypto/sphincsplus/SPHINCSPlusParameters.java

@@ -193,6 +193,7 @@ public static SPHINCSPlusParameters getParams(Integer id)
      * @return the OID for the parameter set.
      * @deprecated Use {@link #getID()} instead
      */
+    @Deprecated
     public static Integer getID(SPHINCSPlusParameters params)
     {
         return params.getID();

core/src/main/java/org/bouncycastle/pqc/crypto/xmss/XMSSMTPrivateKeyParameters.java

@@ -262,6 +262,7 @@ public XMSSMTPrivateKeyParameters build()
     /**
      * @deprecated use getEncoded() - this method will become private.
      */
+    @Deprecated
     public byte[] toByteArray()
     {
         synchronized (this)

core/src/main/java/org/bouncycastle/pqc/crypto/xmss/XMSSMTPublicKeyParameters.java

@@ -144,6 +144,7 @@ public XMSSMTPublicKeyParameters build()
     /**
      * @deprecated use getEncoded() - this method will become private.
      */
+    @Deprecated
     public byte[] toByteArray()
     {
         /* oid || root || seed */

core/src/main/java/org/bouncycastle/pqc/crypto/xmss/XMSSPrivateKeyParameters.java

@@ -350,6 +350,7 @@ public XMSSPrivateKeyParameters build()
     /**
      * @deprecated use getEncoded() - this method will become private.
      */
+    @Deprecated
     public byte[] toByteArray()
     {
         synchronized (this)

core/src/main/java/org/bouncycastle/pqc/crypto/xmss/XMSSPublicKeyParameters.java

@@ -149,6 +149,7 @@ public XMSSPublicKeyParameters build()
     /**
      * @deprecated use getEncoded() - this method will become private.
      */
+    @Deprecated
     public byte[] toByteArray()
     {
         /* oid || root || seed */

core/src/main/java/org/bouncycastle/pqc/crypto/xmss/XMSSStoreableObjectInterface.java

@@ -5,6 +5,7 @@
  *
  * @deprecated use Encodable
  */
+@Deprecated
 public interface XMSSStoreableObjectInterface
 {
 
@@ -13,5 +14,5 @@ public interface XMSSStoreableObjectInterface
      *
      * @return Byte representation of object.
      */
-    public byte[] toByteArray();
+    byte[] toByteArray();
 }

core/src/main/java/org/bouncycastle/pqc/legacy/math/linearalgebra/ByteUtils.java

@@ -7,6 +7,7 @@
  *
  * @deprecated use org.bouncycastle.util.Arrays.
  */
+@Deprecated
 public final class ByteUtils
 {