CI on pull requests

[hannesa2]

Some test are failing with OutOfMemoryException
I started to find workarounds or exclude them, but I stopped this, because for me it's a bigger question:

What are you doing to have that much memory consumption ? Is this really practicable ?

[dghgit]

I'm guessing but are the tests related to Argon2 and Scrypt?

[hannesa2]

Yes, one of them is Argon2Test the others I forgot

[hannesa2]

As long as it's not merged, you see no output. But you can download report from my test-pull request here https://github.com/hannesa2/bouncycastle/pull/1/checks?check_run_id=1902628057

This is the first error

java.lang.OutOfMemoryError: Java heap space
	at org.bouncycastle.crypto.generators.Argon2BytesGenerator$Block.<init>(Argon2BytesGenerator.java:630)
	at org.bouncycastle.crypto.generators.Argon2BytesGenerator$Block.<init>(Argon2BytesGenerator.java:621)
	at org.bouncycastle.crypto.generators.Argon2BytesGenerator.initMemory(Argon2BytesGenerator.java:153)
	at org.bouncycastle.crypto.generators.Argon2BytesGenerator.doInit(Argon2BytesGenerator.java:144)
	at org.bouncycastle.crypto.generators.Argon2BytesGenerator.init(Argon2BytesGenerator.java:74)

[winfriedgerlach]

@hannesa2 @dghgit this PR seems to be severely outdated. Can it be closed?

[hannesa2]

You ignored this contribution for 4 years !
I rebased it, but to be honest, I'm complete out of the loop now

[hannesa2]

When you run the test, you'll see this

e.g this file is missing

[winfriedgerlach]

@hannesa2 are you sure you have followed the instructions from README.md?

Important: You will also need to check out the bc-test-data repository at the same level as the bc-java repository if you want to run the tests.

[hannesa2]

You drive this project without a CI !

This pull request in now just the skeleton of a CI, and a fixing why it not builds properly is out of the scope here and a next step. But I don't invest more time in it, when a pull request is 4 years on hold.

Merge it, then we can see how we continue ...
Or close it

[winfriedgerlach]

OK, let's see whether we get a response from @dghgit , @peterdettman or another dev.

[dghgit]

Apologies for the delay on this, although I think the original issue was fixed. We do use a CI as well, and the file is in bc-test-data - we needed to migrate the test data files out of the main repository as the work on PQC meant the repository was getting overloaded.

If you set up with bc-test-data do things now work for you, or do you still see out of memory errors?

[hannesa2]

You mean this CodeQL https://github.com/bcgit/bc-java/actions ?
If yes, then this would not fulfill my requirements of a CI. I at least would build it

[dghgit]

No, we actually have some local servers which build the repositories on check in. This repository is a mirror.

[hannesa2]

local server

As long as it's not public it's a rumor. I at least don't see any advantage to have these servers private

[dghgit]

It's a little tricky but I'll see if there's someway of getting the reports pushed somewhere public - or at least a report based on what's currently sourced on github public.