Skip to content

DBC22-7351: Switch to new DMS API - #1456

Open
wmuldergov wants to merge 2 commits into
mainfrom
task/DBC22-7351
Open

DBC22-7351: Switch to new DMS API#1456
wmuldergov wants to merge 2 commits into
mainfrom
task/DBC22-7351

Conversation

@wmuldergov

Copy link
Copy Markdown
Collaborator

📝 Submitter

🔗 JIRA Ticket


✅ Quality Assurance & Requirements

  • Requirements Met: I have confirmed that all acceptance criteria from the JIRA ticket are fulfilled.
  • Tested desktop in local or dev envs
  • Tested mobile in local or dev envs
  • Ran unit tests locally
  • SonarCloud: I have verified that the SonarCloud analysis is clean/passing for this branch.

⚙️ Configuration & Environment

  • New Env Variables: Does this PR require new environment variables? (Yes)
    DRIVEBC_DMS_API_BASE_URL1
    DRIVEBC_DMS_API_BASE_URL2
    DRIVEBC_DMS_API_KEY
    DRIVEBC_DMS_API_BASE_URL - Can be removed once released

🧪 How to Test (if required)

  1. Deploy to the dev environment
  2. Wait till the job runs
  3. Confirm that the signs display on DriveBC and in Django Admin. You should be able to tell by checking the id which are just numerical.

🔍 Reviewer Checklist

  • Reviewed code for logic and cleanliness
  • Re-tested desktop/mobile in local or dev envs
  • Verified no new console warnings/errors
  • Confirmed that any new env variables are understood/documented

Comment thread src/backend/apps/feed/client.py Fixed
Co-Authored-By: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants