fix(scripts): prevent false positive phoenix_live_view plugin detection - #121
Merged
Conversation
Optional transitive dependency declarations inside other packages' lock entries matched the old pattern, so repos that never depend on phoenix_live_view got a formatter plugin they cannot compile. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phoenix_live_viewwere gettingPhoenix.LiveView.HTMLFormattertemplated into.formatter.exs, which breaks every Format CI job withFormatter plugin Phoenix.LiveView.HTMLFormatter cannot be found.phoenix_live_viewas an optional dep, since those declarations live inline in other packages'mix.lockentries and matched the unanchored pattern.import_depsdetection already works.polymorphic_embed.