Skip to content

fix(scripts): prevent false positive phoenix_live_view plugin detection - #121

Merged
yordis merged 1 commit into
mainfrom
yordis/fix-formatter-plugin-detection
Sep 1, 2026
Merged

fix(scripts): prevent false positive phoenix_live_view plugin detection#121
yordis merged 1 commit into
mainfrom
yordis/fix-formatter-plugin-detection

Conversation

@yordis

@yordis yordis commented Sep 1, 2026

Copy link
Copy Markdown
Member
  • Downstream repos that do not depend on phoenix_live_view were getting Phoenix.LiveView.HTMLFormatter templated into .formatter.exs, which breaks every Format CI job with Formatter plugin Phoenix.LiveView.HTMLFormatter cannot be found.
  • The trigger is any dependency that declares phoenix_live_view as an optional dep, since those declarations live inline in other packages' mix.lock entries and matched the unanchored pattern.
  • Anchoring on the top-level lock key keeps plugin detection consistent with how import_deps detection already works.
  • Seen in chore: sync files with beam-community/common-config ex_machina#569, which picked up polymorphic_embed.

Optional transitive dependency declarations inside other packages' lock
entries matched the old pattern, so repos that never depend on
phoenix_live_view got a formatter plugin they cannot compile.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis requested a review from a team as a code owner September 1, 2026 13:22
@yordis
yordis merged commit 4d92e6d into main Sep 1, 2026
3 checks passed
@yordis
yordis deleted the yordis/fix-formatter-plugin-detection branch September 1, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant