Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show previous history keybinding in help text #38

Merged
merged 1 commit into from
Aug 6, 2016

Conversation

jacktasia
Copy link
Contributor

As mentioned in #15

@benma
Copy link
Owner

benma commented Jun 29, 2016

Thanks. I don't think this necessary though, as going back in history is a normal Emacs minibuffer feature and not related to visual regexp.

next-history-element, isearch-backward, and the many other bindings are also not in the visual regexp help text, after all.

Thoughts?

@jacktasia
Copy link
Contributor Author

I don't think this necessary

I don't think it's necessary exactly, but it's clearly somewhat of a problem since #15 exists. visual-regexp.el is awesome, but I had come to count on the defaulting to the last search/replace like query-replace-regexp.

as going back in history is a normal Emacs minibuffer feature and not related to visual regexp

This is just a nice reminder of what's possible since emacs is huge and a lot of people use helm things for things that were traditionally minibuffer only...so they may not know about this functionality. For instance, I've used emacs for 7 years and have made a kind of popular emacs plugin and I didn't know I could do this until I saw #15.

and the many other bindings are also not in the visual regexp help text

That's true and I totally understand if you don't merge this, but I feel like this is particularly important functionality to point out since it saves so much time.

So those are my thoughts 😄

@benma benma merged commit 96dea5e into benma:master Aug 6, 2016
@benma
Copy link
Owner

benma commented Aug 6, 2016

Sorry for the long wait. I am on board with your pragmatic approach :) I assumed that basically everybody knew that you can go back in history in the minibuffer, because it is so similar to a linux shell line, and every linux shell supports arrow-up and C-r to browse the history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants