Extract NumberInput component with auto-repeat nudge buttons - #16
Merged
Conversation
Extracts the number input with -/+ nudge buttons from the main calculator into a reusable NumberInput component, and uses it for the Maxes page weight inputs (with ±5 step). https://claude.ai/code/session_01GRvYTjGFpp5DbYqZNtfkFP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the number input UI pattern into a reusable
NumberInputcomponent to reduce code duplication and improve maintainability.Key Changes
Created new
NumberInputcomponent (src/NumberInput.tsx) that encapsulates:useAutoRepeathook logic for button interactionsRefactored
BarComputercomponent to use the newNumberInputcomponent:useAutoRepeathook calls<NumberInput />component callonChangepropRefactored
MaxEditorcomponent to useNumberInput:NumberInputfor consistencyUpdated imports in
App.tsx:useAutoRepeatimport (now internal toNumberInput)NumberInputimportImplementation Details
NumberInputcomponent accepts flexible props via spread operator, allowing customization of standard HTML input attributesstepvalue is providedhttps://claude.ai/code/session_01GRvYTjGFpp5DbYqZNtfkFP