Remove redundant plate filtering from validPlates memo - #18
Merged
Conversation
The range slider step was computed from the globally smallest plate, ignoring per-bar plateThreshold and plateLimits constraints. This caused the slider to offer unreachable weight values. Two fixes: - Filter plates by selected bar's constraints (plateThreshold, plateLimits with count 0) when computing the slider step size - Snap slider onChange to nearest achievable weight via closestTarget Also extracts selected bars into a shared memo to avoid duplicating the bar filter logic between possibleWeights and sliderPlates. https://claude.ai/code/session_011VVJjPYdBePnMQM61MbuY8
Both determineWeightSpace and determinePlates already re-apply bar constraints internally, so filtering earlier in validPlates is safe and removes the unnecessary sliderPlates indirection. https://claude.ai/code/session_011VVJjPYdBePnMQM61MbuY8
determineBarWeightSpace and _greedyPlates already filter plates per-bar (plateThreshold + plateLimits), so the pre-filter was redundant and subtly incorrect (applying a union across all bars rather than per-bar constraints). https://claude.ai/code/session_011VVJjPYdBePnMQM61MbuY8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.