-
Notifications
You must be signed in to change notification settings - Fork 6
Added an additional catch for RecordDeclaration #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MercerK
wants to merge
2
commits into
bensku:master
Choose a base branch
from
MercerK:kmercer/catches-error
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* StructuresLocateEvent leverages a `record` which isn't supported by JavaParser just yet.
Copy of original error.
|
Apologies for slow response. I would prefer to waiting for JavaParser to fix their record support (or alternative, find a workaround that doesn't just ignore records). Since I don't distribute binaries, users need to compile it themself in any case. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I want to start off by stating that this library is amazing. Thank you for your hard work! It is an absolute game changer.
When I was trying to build it against
io.papermc.paper:paper-api:1.19.1-R0.1-SNAPSHOT
, it was failing specifically at https://jd.papermc.io/paper/1.19/io/papermc/paper/event/world/StructuresLocateEvent.html. It seems that JavaParser doesn't understandrecord
just yet (javaparser/javaparser#2446, javaparser/javaparser#3556).I went ahead and added an additional catch, so the tool can still build and updated the JavaParser dependency.
With these changes, I was able to produce: