add API key support in Hermes and Benchmarks clients#6
Conversation
bearmigiano
commented
Jun 17, 2026
- Fix bug which returns a new http client instead of the configured one
- Refactoring clients to use shared HTTP base client
ewokndor
left a comment
There was a problem hiding this comment.
This lgtm. Just one note:
If we are going to deploy this into k8s, then we might be required to load passwords from file, not env vars. You might want to consider supporting this right away.
|
However, note that the tests are not passing |
|
@ewokndor good point in general, but I think it doesn't apply here: this module isn't a deployable, atm it's just a dependency consumed by |
|
|
||
| env: | ||
| GOPATH: /home/runner/go | ||
| PYTH_API_KEY: ${{ secrets.PYTH_API_KEY }} |
There was a problem hiding this comment.
Do we actually run real tests against pyth? Because this would require to add the API_KEY just for tests? That feels awkward, if that is what's happening, we should mock the according test.
There was a problem hiding this comment.
Unless there's a reason for it which I am not seeing.
There was a problem hiding this comment.
OK the client just calls pyth and nothing else, test makes no sense without
|
|
||
| env: | ||
| GOPATH: /home/runner/go | ||
| PYTH_API_KEY: ${{ secrets.PYTH_API_KEY }} |
There was a problem hiding this comment.
OK the client just calls pyth and nothing else, test makes no sense without