Enable system locale - change from the standard (C) to system locale. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows libarchive (in case it is activated) to handle filenames. We only change LC_CTYPE since libarchive only needs the charset set. We don't use LC_ALL because it causes problems on some systems. We restore the original LC_CTYPE after extraction to avoid side effects. We use uselocale instead of setlocale to avoid setting LC_CTYPE globally. See on libarchive Website for a more complete description of the issue: libarchive/libarchive#587 https://github.com/libarchive/libarchive/wiki/Filenames https://github.com/sbabic/swupdate/blob/master/handlers/archive_handler.c#L94
|
Without it, handling a tarball in pax format containing utf8 characters in its filenames will result in this error message: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows libarchive (in case it is activated) to handle filenames.
We only change LC_CTYPE since libarchive only needs the charset set.
We don't use LC_ALL because it causes problems on some systems.
We restore the original LC_CTYPE after extraction to avoid side effects.
We use uselocale instead of setlocale to avoid setting LC_CTYPE globally.
See on libarchive Website for a more complete description of the issue:
libarchive/libarchive#587
https://github.com/libarchive/libarchive/wiki/Filenames
https://github.com/sbabic/swupdate/blob/master/handlers/archive_handler.c#L94