fix: remove redundant CHR bank loads in CNROM (Mapper 3)#649
Merged
Conversation
The two loadVromBank calls were immediately overwritten by load8kVromBank, which does the same work internally. Fixes #597 (issue 2). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadVromBankcalls in Mapper 3 (CNROM) that were immediately overwritten byload8kVromBank, which internally callsloadVromBankfor both 4KB halvesPartial fix for #597 (issue 2).
Test plan
npm testpasses🤖 Generated with Claude Code