fix(apu): correct square sweep negate and overflow mute threshold#651
Open
SergioChan wants to merge 1 commit intobfirsh:mainfrom
Open
fix(apu): correct square sweep negate and overflow mute threshold#651SergioChan wants to merge 1 commit intobfirsh:mainfrom
SergioChan wants to merge 1 commit intobfirsh:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
period - (period >> shift) - 1behavior0x7ff) instead of4095in both sweep update and sample muting checkssrc/papu/channel-square.jswith no unrelated behavior updatesTesting
npm test -- --runInBand test/apu.test.js(passes; project test runner executes its full configured suite with all tests passing)Related
Fixes #608