-
Notifications
You must be signed in to change notification settings - Fork 189
[ENH] Schema changes related to BEP032 #1826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
particiapants.tsv for BEP032participants.tsv for BEP032
participants.tsv for BEP032for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@ree-gupta Thanks again for working on this! Could you please "enable" |
Sure thing! Thank you for the suggestion. |
…gin and setup fields
| height__probes: optional | ||
| depth__probes: optional | ||
| dimension_unit: optional | ||
| alpha_rotation: recommended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ree-gupta can you please delete this so it shows the latest changes google docs?
It is optional, and adding does not solve anything but makes it consistent with the other files in the folder
|
Took me awhile, even sent complimentary #1963 to see the obvious gotcha! ;) pushed the fix -- hopefully gets green now @ree-gupta ! Thanks again for working on this!!! edit: CI is green where we care. |
Thank you for spotting and fixing this @yarikoptic! 🙏🏽 the schema validation check passes now. |
| alpha_rotation: recommended | ||
| beta_rotation: recommended | ||
| gamma_rotation: recommended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| alpha_rotation: recommended | |
| beta_rotation: recommended | |
| gamma_rotation: recommended |
ageFormalize participants' age to clarify the reference point #1634surgery_date_probes.tsv_probes.tsv_electrodes.tsv_electrodes.tsv_channels.tsv_channels.tsv_scans.tsv--> not required as already inherited from main BIDS_scans.tsv--> not required as already inherited from main BIDS_events.tsv_events.tsv_coordsystem.json_ephys.json(except probe information as decision pending)for e.g.-> for example,@bids-standard/bep032