Skip to content

[ENH] add BEP 0XX - Cardiac MRI #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

[ENH] add BEP 0XX - Cardiac MRI #613

wants to merge 10 commits into from

Conversation

@Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Feb 4, 2025

No description provided.

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Feb 4, 2025

@christinerogers this cannot be merged unless a link to the google doc is provided

@Remi-Gau
Copy link
Contributor Author

Remi-Gau commented Feb 4, 2025

Also this is going to require some update of the list of contributors in the spec:

045 Cardiac MRI (CMR)
NOT FOUND Edward Xu
FOUND Jefferson Casimir
FOUND Ghislain Vaillant
no email in specification/CITATION.cff.

Remi-Gau
Remi-Gau commented Feb 4, 2025
View reviewed changes
@christinerogers
Copy link
Contributor

this follows on from #611 #612

@christinerogers christinerogers mentioned this pull request Feb 10, 2025
Merged
@effigies
Copy link
Contributor

#618 has a BEP 045 already ready to go. Should we renumber this one to 046 while we wait for it?

@christinerogers
Copy link
Contributor

christinerogers commented Feb 17, 2025 •
edited
Loading

#618 has a BEP 045 already ready to go. Should we renumber this one to 046 while we wait for it?

sure, i've renamed it to 046 everywhere, added the googledoc (now open) and invited Ghislain .

cc @Remi-Gau - ready for your review

@christinerogers christinerogers changed the title [ENH] add BEP 045 [ENH] add BEP 046 Feb 17, 2025
christinerogers
christinerogers reviewed Feb 19, 2025
View reviewed changes
@christinerogers
Copy link
Contributor

Also this is going to require some update of the list of contributors in the spec:

045 Cardiac MRI (CMR) NOT FOUND Edward Xu FOUND Jefferson Casimir FOUND Ghislain Vaillant no email in specification/CITATION.cff.

@Remi-Gau I think i've addressed all of this including an email in the beps.yml
not sure if i need to make further changes to resolve the Citation.cff issue?

@christinerogers christinerogers changed the title [ENH] add BEP 046 [ENH] add BEP 046- Cardiac MRI Feb 20, 2025
Remi-Gau and others added 5 commits March 6, 2025 13:31
@christinerogers
Copy link
Contributor

thanks @effigies No merge for now, pending further discussion

christinerogers
christinerogers reviewed Mar 10, 2025
View reviewed changes
@effigies effigies marked this pull request as draft May 30, 2025 18:56
@effigies effigies changed the title [ENH] add BEP 046- Cardiac MRI [ENH] add BEP 0XX - Cardiac MRI May 30, 2025
@effigies
Copy link
Contributor

Converting to draft and freeing up BEP46.

effigies
effigies reviewed May 30, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@effigies effigies effigies left review comments

@christinerogers christinerogers christinerogers left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Remi-Gau @christinerogers @effigies