Landing page #725
Landing page #725
Conversation
for more information, see https://pre-commit.ci
…pfarr/bids-website into landing_page
|
I don't know why it doesn't show the background image and the images in the sponsors section, it works in my local build |
julia-pfarr
requested review from
astewartau,
bendhouseart,
effigies and
yarikoptic
https://bids-website--725.org.readthedocs.build/en/assets/img/logos/NIH.png instead of https://bids-website--725.org.readthedocs.build/en/725/assets/img/logos/NIH.png Not sure how to fix that... |
Co-authored-by: Chris Markiewicz <[email protected]>
|
nice, this worked, thanks @effigies |
There was a problem hiding this comment.
not opposed to having a PR template even if this is is out of the scope of the PR. 😉
maybe let's stick to a single template for now and name it: .github/pull_request_template.md
There was a problem hiding this comment.
sorry, I didn't know this one slipped in here. I'll change the name. I just wasn't sure if I could remove the other one, because there was already one but I didn't see it being used in the PRs here, so I was confused
There was a problem hiding this comment.
not a big fan of ducplicating files that we can already exist from the specification sudmodule, maybe just copy it during the build process? or symlink to it?
There was a problem hiding this comment.
Ok, I haven't been working with submodules that much, so didn't know about that. Will change.
There was a problem hiding this comment.
@Remi-Gau I tried it with the submodule, but the logo doesn't show in the preview. Could you make a suggestion for how to solve this?
| </div> | ||
| </section> | ||
|
|
||
| <!-- Stats/Social proof section --> |
There was a problem hiding this comment.
I think for those we could maybe add links to the other relevant sections of the website
There was a problem hiding this comment.
You mean that if I click on "2000+ public datasets", for example, it should direct me to the "Datasets" section of our BIDS website?
| </div> | ||
| </div> | ||
| </section> | ||
|
|
There was a problem hiding this comment.
I feel we should have a 2 liners text describing BIDS below the hero and the feature section, otherwise it feels a bit empty
Or simpler reduce vertical spacing the mdx-containers?
There was a problem hiding this comment.
maybe reduce the vertical spacing because in the feature section there is already text describing BIDS? But I'm fine with either. After the feature section I also feel like we need something between feature and stats section. Do you have an idea for a nice figure @Remi-Gau ? Nothing too complex. Like the current one I (this mermaid diagram) I find too intimidating for the landing page :-D
There was a problem hiding this comment.
Or maybe add the benefits section from the current one?
There was a problem hiding this comment.
wonder if we could use scss to make it easier to navigate the css overall, seems that mkdocs material does it but it is not mentioned in the mkdocs so I figure we may have to generate the css at build time
| margin-left: 0 !important; | ||
| } | ||
|
|
||
| /* Mobile adjustments */ |
There was a problem hiding this comment.
I think there are some issues with the look on tablet and mobile but I would leave this kind of tweaking to a follow up PR.
There was a problem hiding this comment.
to make the review easier we could keep all the @media adjustements for a follow up PR
There was a problem hiding this comment.
Yes, good idea. And yes, I haven't been paying attention to tablet and phone adjustments, just focused on keeping the stuff going for laptop
4 participants
I made a first draft for the modified landing page. Please give input on
Also, since I am not super skilled with html, please review the code and refactor. I guess there's also a lot in the code that is actually not needed/used or could be simplified. I didn't do a proper code review in the end because I am just happy that I got this far at all :-D
I am also imagining some nice figure between the "in a nutshell" and the "stats" section, does anyone have an idea?
📚 Documentation preview 📚: https://bids-website--725.org.readthedocs.build/en/725/