Skip to content

Hunter/vib 4100 productcard props changed by card site theme #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: integrations/makeswift
Choose a base branch
from

Conversation

hunterbecton
Copy link
Contributor

What/Why?

  • fixes issues where ProductCard site settings were not properly mapped
  • fixes error being thrown when adding individual ProductCard to the MS editor by setting showCompare false

Testing

CleanShot.2025-04-03.at.13.45.12.mp4

@hunterbecton hunterbecton requested a review from a team as a code owner April 3, 2025 17:49
Copy link

linear bot commented Apr 3, 2025

Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2025 6:03pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Apr 3, 2025 6:03pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2025 6:03pm
catalyst-soul ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2025 6:03pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2025 6:03pm

@hunterbecton hunterbecton force-pushed the hunter/vib-4100-productcard-props-changed-by-card-site-theme branch from 3bb0842 to c33a404 Compare April 3, 2025 17:50
Copy link

changeset-bot bot commented Apr 3, 2025

⚠️ No Changeset found

Latest commit: 35e6431

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hunterbecton hunterbecton force-pushed the hunter/vib-4100-productcard-props-changed-by-card-site-theme branch from c33a404 to 35e6431 Compare April 3, 2025 18:01
Copy link
Contributor

github-actions bot commented Apr 3, 2025

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-canary-qt34zjbk1-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 92
🟠 Best practices 78
🟢 SEO 91

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 59
🟢 Accessibility 92
🟠 Best practices 78
🟢 SEO 92

Copy link
Contributor

@jorgemoya jorgemoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you notice in issues when migrating the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants