Conversation
TomA-R
marked this pull request as ready for review
August 13, 2026 06:16
bc-maxy
reviewed
Aug 13, 2026
bc-maxy
reviewed
Aug 13, 2026
| "build": "tsc --outDir lib --project tsconfig.json", | ||
| "lint": "eslint 'src/**/*.ts' && tsc --noEmit", | ||
| "prepare": "check-node-version --node '>=10' --npm '>=6' && npm run build", | ||
| "prepare": "check-node-version --node '>=26' --npm '>=11' && npm run build", |
There was a problem hiding this comment.
Any specific reason we are bumping it to 26? Recommended node for production right now is 24.19.0 (LTS version), should we allow it as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: PHPMNT-394
What/Why?
Upgrade to Node.js to v26 to stay up to date. Node 20 is EOL
Rollout/Rollback
Merge / revert
Testing
CI on this PR