whepfrom:datachannel realization and udp extension#352
Open
yingchuan8985 wants to merge 5 commits into
Open
Conversation
a-wing
reviewed
Apr 27, 2026
Member
a-wing
left a comment
a-wing
left a comment
There was a problem hiding this comment.
Add a Integration testing in: tests/channel
up a liveion and whepfrom service and:
integration test: udp <-> liveion <-> whepfrom <-> udp
a-wing
reviewed
May 10, 2026
Member
a-wing
left a comment
a-wing
left a comment
There was a problem hiding this comment.
If rtp port use portpicker, The test is more failed
static port more easy success for test
Comment on lines
+102
to
+108
| let handle_whip = tokio::spawn(livetwo::whip::into( | ||
| ct.clone(), | ||
| sdp_path, | ||
| format!("http://{addr}{}", api::path::whip(stream_id)), | ||
| None, | ||
| None, | ||
| )); |
Member
There was a problem hiding this comment.
When I use liveion datachannel, We must have whip publisher?
Can I only stream and whepfrom use liveion datachannel udp?
yingchuan8985
force-pushed
the
feat/whepfrom
branch
from
5b06260 to
ab70673
Compare
yingchuan8985
force-pushed
the
feat/whepfrom
branch
from
ab70673 to
4aac2f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.