Allow hostnames in the allowed_ips list - good for DynDNS.#43
Open
jeremitu wants to merge 2 commits intobiola:masterfrom
Open
Allow hostnames in the allowed_ips list - good for DynDNS.#43jeremitu wants to merge 2 commits intobiola:masterfrom
jeremitu wants to merge 2 commits intobiola:masterfrom
Conversation
Collaborator
|
Hi @jeremitu. My apologies in being so very late to getting to this. I'm not opposed to adding support for domain names and the implementation looks good enough to me. But I'd definitely want to see some RSpec tests for this before it's merged. I'm also a bit concerned about performance. Could you either post some performance comparisons or make this something that can be explicitly enabled via a configuration option? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My IP at home changes every day - that's why I needed an option to add hostnames to allowed IPs.