Skip to content

Update quantile calculation method in owboxplot.py - #7305

Merged
janezd merged 1 commit into
biolab:masterfrom
Hellseher:patch-1
Jun 30, 2026
Merged

Update quantile calculation method in owboxplot.py#7305
janezd merged 1 commit into
biolab:masterfrom
Hellseher:patch-1

Conversation

@Hellseher

Copy link
Copy Markdown
Contributor

The parameter name has been changed in NumPy 1.22

methodstr, optional

    This parameter specifies the method to use for estimating the quantile. There are many different methods, some unique to NumPy. See the notes for explanation. The options sorted by their R type as summarized in the H&F paper [1] are:

        ‘inverted_cdf’

        ‘averaged_inverted_cdf’

        ‘closest_observation’

        ‘interpolated_inverted_cdf’

        ‘hazen’

        ‘weibull’

        ‘linear’ (default)

        ‘median_unbiased’

        ‘normal_unbiased’

    The first three methods are discontinuous. NumPy further defines the following discontinuous variations of the default ‘linear’ (7.) option:

        ‘lower’

        ‘higher’,

        ‘midpoint’

        ‘nearest’

    Changed in version 1.22.0: This argument was previously called “interpolation” and only offered the “linear” default and last four options.

https://numpy.org/doc/stable/reference/generated/numpy.nanquantile.html

Issue
Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

The parameter name has been changes in NumPy 1.22
```
methodstr, optional

    This parameter specifies the method to use for estimating the quantile. There are many different methods, some unique to NumPy. See the notes for explanation. The options sorted by their R type as summarized in the H&F paper [1] are:

        ‘inverted_cdf’

        ‘averaged_inverted_cdf’

        ‘closest_observation’

        ‘interpolated_inverted_cdf’

        ‘hazen’

        ‘weibull’

        ‘linear’ (default)

        ‘median_unbiased’

        ‘normal_unbiased’

    The first three methods are discontinuous. NumPy further defines the following discontinuous variations of the default ‘linear’ (7.) option:

        ‘lower’

        ‘higher’,

        ‘midpoint’

        ‘nearest’

    Changed in version 1.22.0: This argument was previously called “interpolation” and only offered the “linear” default and last four options.
```
https://numpy.org/doc/stable/reference/generated/numpy.nanquantile.html
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Hellseher

Copy link
Copy Markdown
Contributor Author

CLA is a great tool to cool-down contribution ;-)
I tried to fix tests for Orange3 in Guix and noticed the most of them errored, complaining on incorrect parameter (see attached NumPy documentation part)

@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.96%. Comparing base (f6a9710) to head (7e1e48f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7305      +/-   ##
==========================================
- Coverage   88.98%   88.96%   -0.03%     
==========================================
  Files         336      336              
  Lines       74515    74515              
==========================================
- Hits        66306    66290      -16     
- Misses       8209     8225      +16     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janezd

janezd commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@janezd
janezd merged commit 7767f9f into biolab:master Jun 30, 2026
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants