Add type hinting support for the biothings-client#45
Merged
Conversation
This is a very small difference, given TypedDict is viewed as a Dict at runtime. TypedDict is has contraints on what the types of the keys are for the dictionary, but given the way we're using it is deprecated in python 3.13 and will be removed by python 3.15, I think it's better to be more generic in what we assert is in the dictionary for backwards compatibility https://docs.python.org/3/library/typing.html#typing.TypedDict https://typing.python.org/en/latest/spec/typeddict.html#
typing.Literal only got added in python 3.8, so we using this extension for python 3.7
ctrl-schaff
requested review from
DylanWelzel,
everaldorodrigo,
jal347,
newgene and
shuchenliu
Contributor
Author
|
@newgene I've added the py.typed file to the package. From my testing it appears to be automatically picked up in the package upon pip install. I've also conditionally gated the packages by python version for the type backporting |
newgene
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.