draft: Introduce system theme detection for macOS #340
+144
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarolrod
added
enhancement
Contributor
Author
|
We would then iteratively add this detection for Linux (where possible, looking at the dconf values for WM specific theme settings like gnome and kde), Windows (looking at the registry) and Android. |
jarolrod
force-pushed
the
theme-manager
branch
from
9918383 to
8f5c45d
Compare
Contributor
Author
|
rebased over main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #311, only last commit belongs to this PR
Introduces the basic wiring for detecting the system theme, and only does so for macOS here. Opening as draft for developer feedback on implementation of the idea of the theme manager.