-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate the use of points and scalars from secp256k1_ecmult_strauss_batch. #900
Closed
roconnor-blockstream
wants to merge
8
commits into
bitcoin-core:master
from
roconnor-blockstream:20210301-no-points-scalars
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
350ceba
Eliminate the prej array from ecmult_strauss_wnaf.
roconnor-blockstream ee03b34
Remove the unused prej allocations.
roconnor-blockstream c48a9f0
Eliminate the pre_a_lam array from ecmult_strauss_wnaf.
roconnor-blockstream 508f659
Remove the unused pre_a_lam allocations.
roconnor-blockstream 80e9193
Eliminate na_1 and na_lam state fields from ecmult_strauss_wnaf.
roconnor-blockstream 5aea2e8
Eliminate input_pos state field from ecmult_strauss_wnaf.
roconnor-blockstream 8242379
Eliminate the use of points and scalars from secp256k1_ecmult_strauss…
roconnor-blockstream 29a1b7e
Remove the unused points and scalars allocation from secp256k1_ecmult…
roconnor-blockstream File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're checking the return value of
secp256k1_ecmult_strauss_wnaf
when you call it here, would you also need to check it when you call it at the end ofsecp256k1_ecmult
?My concern is that if the callback (and thus the call to
secp256k1_ecmult_strauss_wnaf
) "fails", this could either (1) introduce a way forsecp256k1_ecmult
to fail unexpectedly, or (2) forcesecp256k1_ecmult
to returnint
instead ofvoid
, and either way this would break the "public" API.