sim-ln/refactor: Update help, add new cmds in Makefile #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlaKC
reviewed
Mar 28, 2025
Makefile
Outdated
| @@ -39,8 +45,8 @@ check-code: | |||
|
|
|||
| stable-output: | |||
| @if [ -n "$$(git status --porcelain)" ]; then \ | |||
| echo "Error: There are unstaged or uncommitted changes after running 'make check-code'."; \ | |||
| exit 1; \ | |||
| echo "Error: There are unstaged or uncommitted changes after running 'make check-code'."; \ | |||
There was a problem hiding this comment.
Let's move formatting fixes into a separate commit?
carlaKC
reviewed
Apr 1, 2025
There was a problem hiding this comment.
A few high level things that I'd like to get straightened out:
- Formatting changes / trivial typos should go in their own commits (not with functionality)
- Changes should be pushed as fixup commits
Happy for you to do one big restructure + squash to get this right, and then go with fixups thereafter. I know that this may seem overly pedantic, but it makes a big difference to the maintainability of the codebase and our ability to debug it to do things in a standard way.
jirigrill
force-pushed
the
makefile-refactoring
branch
from
dc03c80 to
5044fb7
Compare
|
@carlaKC thank you for your feedback. I have reset the commits to follow your suggestion. Let me know if now it looks you expected. |
jirigrill
force-pushed
the
makefile-refactoring
branch
from
7dab2f9 to
bd24179
Compare
carlaKC
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.