docs: Outline preferred commit structure and use of fixups#250
Merged
carlaKC merged 2 commits intobitcoin-dev-project:mainfrom Apr 2, 2025
Merged
docs: Outline preferred commit structure and use of fixups#250carlaKC merged 2 commits intobitcoin-dev-project:mainfrom
carlaKC merged 2 commits intobitcoin-dev-project:mainfrom
Conversation
f3r10
approved these changes
Apr 2, 2025
Collaborator
f3r10
left a comment
f3r10
left a comment
There was a problem hiding this comment.
LGTM!!
Would it be necessary to mention the preferred commit naming? (ej: sim-ln/refactor, sim-cli/test ...)
Contributor
Author
Oh yes, great idea! |
carlaKC
force-pushed
the
contributing-details
branch
2 times, most recently
from
e425104 to
2ed2b58
Compare
carlaKC
force-pushed
the
contributing-details
branch
from
2ed2b58 to
61740fd
Compare
Contributor
Author
|
Added instructions for commit titles, flipped on auto merge for when CI passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite a few new people have showed up recently, updating docs add instructions for some of the most common missteps I've been seeing.