-
Notifications
You must be signed in to change notification settings - Fork 63
deps: uniffi 0.30.0 #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: uniffi 0.30.0 #883
Conversation
|
@thunderbiscuit + @ItoroD this is just a draft/experiment on 2 new things in uniffi 0.30.0 |
|
We can probably do this bump to 0.30.0 now that 2.2.0 is released. It just needs a rebase and a clear vision for the Ord + Hashable stuff. We can then figure out if the new Display on the Errors is a breaking change (I don't actually think it is?), but that can come in a separate PR. |
ok so 2 commits now, one just bumping to 0.30.0, and the other (which we can keep in this pr or spin out into another pr, whatever is cool w me) is relating to the ord+hashable stuff. in that second commit 9fa0fa0 I'm applying it for BlockHash, Txid, Wtxid, DescriptorId, and TxMerkleNode Before this BDK iOS app would have had to compare txids indirectly But after this change the generated Swift bindings now declare those types as |
thunderbiscuit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 9fa0fa0.
Description
Testing uniffi 0.30.0
Two changes:
0. bumping to 0.30.0
Notes to the reviewers
Tested out this other thing along the way but didn't work
2.
(breaking! but potentially awesome) convert HashableOutPoint from an object to a record "Enums and Records can have methods"compiles but exporting our own methods on a record fails in bindgen stepChangelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: