Skip to content

upgrading to match bdk v0.30 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2025
Merged

upgrading to match bdk v0.30 #38

merged 2 commits into from
May 1, 2025

Conversation

ulrichard
Copy link
Collaborator

No description provided.

@ulrichard ulrichard force-pushed the feature/v0_30 branch 4 times, most recently from ad9a31f to 0bf0a7c Compare January 9, 2025 09:32
@ulrichard ulrichard marked this pull request as ready for review January 9, 2025 09:44
@notmandatory
Copy link
Member

I recommend bumping to 0.30.2, you're unlikely to see the issue fixed in this release but best to be on the latest just in case.
https://github.com/bitcoindevkit/bdk/releases/tag/v0.30.2
Otherwise ACK for this PR.

@notmandatory
Copy link
Member

notmandatory commented Apr 26, 2025 •
edited
Loading

Looks like you'll need to update the WASM ubuntu version to ubuntu-latest and something changed with your gpg signature email. See: https://docs.github.com/github/authenticating-to-github/displaying-verification-statuses-for-all-of-your-commits

"The email in this signature doesn’t match the committer email. GPG Key ID: B37F658367A845DC"

@ulrichard
Copy link
Collaborator Author

I had to re-upload the GPG key, so that the UID with the amina address was included.
The WASM stuff never worked, so I just removed it from the CI. The problem I faced was:
rust-bitcoin/rust-bitcoinconsensus#32

notmandatory
notmandatory approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK dfcbe50

@notmandatory
Copy link
Member

I removed wasm and updated the build job rust version for the required checks on this repo

@notmandatory notmandatory mentioned this pull request Apr 30, 2025
Open
@ulrichard ulrichard merged commit eaed100 into bitcoindevkit:main May 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees

@ulrichard ulrichard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulrichard @notmandatory