update bitcoin to 0.31.2 #1300
Closed
update bitcoin to 0.31.2 #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey, I still haven't looked at the code in depth, but I have a few comments:
- You are upgrading the project MSRV from 1.63 to 1.70 - that's not a change we take lightly, is there any reason behind it? Has this been discussed with the team?
- Commits should be atomic and hygienic, and the message should explain what you're doing. You currently have multiple commits doing the same thing, which should be squashed together. I suppose this PR should have one commit updating to rust-bitcoin 0.31 + more commits if you're doing something else (updating the MSRV, for example, would need its own commit). More info here: https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#committing-patches or here: https://blog.lanesawyer.dev/17501/git-hygiene
- The CI is currently failing, can you look into that please?
| @@ -12,7 +12,7 @@ jobs: | |||
| rust: | |||
| - version: stable | |||
| clippy: true | |||
| - version: 1.63.0 # MSRV | |||
There was a problem hiding this comment.
Why are you updating the project MSRV?
|
I have not finished the upgrade code, some code test are not passed. |
|
No problem! I suggest you keep this PR in draft in the meantime, then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingwait for