DEMO: Depend on a new psbt-v0 crate #1621
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Please see simpler idea posted below before bothering to read this.
TL;DR What if we created a
psbt
crate in thegithub.com/rust-bitcoin
org?This is just an idea, raising a PR to see if you guys would likely get behind it and/or involved.
This PR shows the diff required to make it work. The diff is on purpose verbose, it could be made much smaller. I did it like this as a demo to make sure I got everything.
I've hacked up a new
psbt-v0
crate with the goals of:rust-bitcoin v0.32.2
andrust-miniscript 12.0.0
with minimal changes so it can be diff'ed an verified.psbt
modules inbitcoin
andminiscript
.This hopes to enable the following:
rust-bitcoin
My claim is that PSBT has different stakeholders to other code in
bitcoin
andminiscript
and the fact that it lives in these two crates (specificallybitcoin
) makes it harder to attract devs and harder to patch than necessary.github: https://github.com/tcharding/rust-psbt-v0
Potential Roadmap:
v0.1.0
would be the drop in replacement with minimal changes. Next we could potentially do:notes on testing
If you want to prove this works you'll need something like