update rand to 0.9

[getong]

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[YuriQueirozAndrade]

WIP ?

[getong]

WIP ?

forgot to update comment, sorry

[YuriQueirozAndrade]

ok, good, but when I compile (I run cargo check and cargo build, I get the same errors), I get these errors, my question about WIP is because of these errors, in your environment the compile is clean ?

• Errors:

  error[E0277]: the trait bound `ThreadRng: rand_core::CryptoRng` is not satisfied
     --> crates/wallet/src/keys/mod.rs:647:47
      |
  647 |         Self::generate_with_aux_rand(options, &mut bitcoin::key::rand::thread_rng())
      |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `DerefMut` is not implemented for `ThreadRng`
      |
  note: there are multiple versions of `rand_core` in the dependency graph
     --> /home/yuri/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rand_core-0.9.3/src/lib.rs:204:1
      |
  204 | pub trait CryptoRng: RngCore {}
      |
  note: required by a bound in `GeneratableKey::generate_with_aux_rand`
     --> crates/wallet/src/keys/mod.rs:655:25
      |
  655 |     rng: &mut (impl CryptoRng + RngCore),
      |                         ^^^^^^^^^ required by this bound in `GeneratableKey::generate_with_aux_rand`

  error[E0277]: the trait bound `ThreadRng: rand_core::RngCore` is not satisfied
     --> crates/wallet/src/wallet/tx_builder.rs:660:35
      |
  660 |         self.finish_with_aux_rand(&mut bitcoin::key::rand::thread_rng())
      |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `DerefMut` is not implemented for `ThreadRng`
      |
  note: there are multiple versions of `rand_core` in the dependency graph
     --> /home/yuri/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rand_core-0.9.3/src/lib.rs:130:1
      |
  130 | pub trait RngCore {}
      |
  note: required by a bound in `TxBuilder::<'_, Cs>::finish_with_aux_rand`
     --> crates/wallet/src/wallet/tx_builder.rs:673:54
      |
  673 |     pub fn finish_with_aux_rand(self, rng: &mut impl RngCore) -> Result<Psbt, CreateTxError> {
      |                                               ^^^^^^^ required by this bound in `TxBuilder::<'_, Cs>::finish_with_aux_rand`

Another thing, try using conventional commits, I believe you can gain more visibility from reviewers that way

[getong]

oh, i see the error too.
And I make a pr to this, rust-bitcoin/rust-secp256k1#783
wait for this.

[thunderbiscuit]

@getong please consider writing good descriptions for your PRs, particularly as a first-time contributor. Why the bump? Did you run into issues? Is it a security fix? Are you just trying to keep all our dependencies up to date one at a time?

BDK is a big project with tons of users and contributors. If you'd like to see your PR merged, it needs to meet the bar for high quality open source contributions. Cheers!